From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2] ARM: dts: tegra114: dalmore: fix the irq trigger type of Palmas MFD device
Date: Fri, 26 Jul 2013 09:16:36 -0600 [thread overview]
Message-ID: <51F292D4.9030208@wwwdotorg.org> (raw)
In-Reply-To: <1374663272-9937-1-git-send-email-josephl@nvidia.com>
On 07/24/2013 04:54 AM, Joseph Lo wrote:
> The IRQ trigger type of Palmas MFD device (tps65913) is edge trigger. The
> wrong configuration would cause an interrupt storm when booting the
> system. Fixing it in DT with appropriate interrupt type.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> palmas: tps65913 {
> compatible = "ti,palmas";
> reg = <0x58>;
> - interrupts = <0 86 0x4>;
> + interrupts = <0 86 0x0>;
The legal values for that final cell are:
- bits[3:0] trigger type and level flags
1 = low-to-high edge triggered
2 = high-to-low edge triggered
4 = active high level-sensitive
8 = active low level-sensitive
0 isn't one of those values. This patch can't be correct.
BTW, this cell should use the constants from
<dt-bindings/interrupt-controller/irq.h>.
next prev parent reply other threads:[~2013-07-26 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 10:54 [PATCH V2] ARM: dts: tegra114: dalmore: fix the irq trigger type of Palmas MFD device Joseph Lo
2013-07-24 11:10 ` Laxman Dewangan
2013-07-26 15:16 ` Stephen Warren [this message]
2013-07-30 9:46 ` Joseph Lo
2013-07-30 16:24 ` Stephen Warren
2013-07-31 9:10 ` Joseph Lo
2013-07-31 17:08 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F292D4.9030208@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox