From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/3] ARM: bcm281xx: Device Tree bindings for GPIO driver
Date: Fri, 26 Jul 2013 16:08:59 -0600 [thread overview]
Message-ID: <51F2F37B.8030306@wwwdotorg.org> (raw)
In-Reply-To: <1374870345-8276-3-git-send-email-markus.mayer@linaro.org>
(CC'ing the DT bindings maintainers hence quoting the binding in full)
On 07/26/2013 02:25 PM, Markus Mayer wrote:
Some kind of patch description is always useful.
> .../devicetree/bindings/gpio/gpio-bcm-kona.txt | 41 ++++++++++++++++++++
> arch/arm/boot/dts/bcm11351.dtsi | 16 ++++++++
It's more usual to put the DT binding doc change and driver change in
one patch, then "make use of that" in a later separate patch which edits
*.dts and *.dtsi.
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-bcm-kona.txt b/Documentation/devicetree/bindings/gpio/gpio-bcm-kona.txt
> +Broadcom Kona Family GPIO
> +-------------------------
> +
> +This GPIO driver is used in the following Broadcom SoCs:
> + BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
> +
> +The GPIO controller only supports edge, not level triggering.
add "... of interrupts"? This might not be worth mentioning; it's
clearly spelled out in the description of the interrupt cells below.
> +Required properties:
> + - compatible: "brcm,kona-gpio"
> + - reg: Physical base address and length of the controller's registers.
> + - interrupts: The interrupt outputs from the controller.
How many entries are required? I notice there's more than 1 in the
example below.
> + - #gpio-cells: Should be <2>. The first cell is the pin number, the second
> + cell is used to specify optional parameters:
> + - bit 0 specifies polarity (0 for normal, 1 for inverted)
> + - #interrupt-cells: Should be <2>. The first cell is the GPIO number.
> + The second cell is used to specify flags:
> + - trigger type (bits[1:0]):
> + 1 = low-to-high edge triggered.
> + 2 = high-to-low edge triggered.
> + 3 = low-to-high or high-to-low edge triggered
> + Valid values are 1, 2, 3
> + - gpio-controller: Marks the device node as a GPIO controller.
> + - interrupt-controller: Marks the device node as an interrupt controller.
> +
> +Example:
> + gpio: gpio at 35003000 {
> + compatible = "brcm,kona-gpio";
> + reg = <0x35003000 0x800>;
> + interrupts =
> + <0x0 106 0x4
> + 0x0 115 0x4
> + 0x0 114 0x4
> + 0x0 113 0x4
> + 0x0 112 0x4
> + 0x0 111 0x4>;
> + #gpio-cells = <2>;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + interrupt-controller;
> + };
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> + gpio: gpio at 35003000 {
> + compatible = "brcm,kona-gpio";
In order to enable any later chip-specific quirking requirements, that
compatible property should both specify the IP block and the specific
chip it's included in, so I'd expect to see something like:
compatible = "brcm,brcm11351-gpio", "brcm,kona-gpio";
next prev parent reply other threads:[~2013-07-26 22:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 20:25 [PATCH v3 0/3] ARM: bcm281xx: GPIO driver Markus Mayer
2013-07-26 20:25 ` [PATCH v3 1/3] ARM: bcm281xx: Add " Markus Mayer
2013-08-01 18:20 ` Sudeep KarkadaNagesha
2013-08-07 23:52 ` Markus Mayer
2013-07-26 20:25 ` [PATCH v3 2/3] ARM: bcm281xx: Device Tree bindings for " Markus Mayer
2013-07-26 22:08 ` Stephen Warren [this message]
2013-07-26 22:51 ` Markus Mayer
2013-07-26 23:09 ` Stephen Warren
2013-07-26 23:22 ` Markus Mayer
2013-07-27 0:13 ` Tim Kryger
2013-08-16 12:51 ` Linus Walleij
2013-08-19 18:41 ` Markus Mayer
2013-07-26 20:25 ` [PATCH v3 3/3] ARM: bcm281xx: Enable " Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F2F37B.8030306@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox