From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework
Date: Mon, 29 Jul 2013 21:00:58 +0530 [thread overview]
Message-ID: <51F68AB2.5090402@ti.com> (raw)
In-Reply-To: <023801ce8c70$427cbd20$c7763760$%debski@samsung.com>
On Monday 29 July 2013 08:58 PM, Kamil Debski wrote:
> Hi Kishon,
>
> A small fix follows inline.
>
>> From: linux-media-owner at vger.kernel.org [mailto:linux-media-
>> owner at vger.kernel.org] On Behalf Of Kishon Vijay Abraham I
>> Sent: Friday, July 26, 2013 2:49 PM
>>
>> The PHY framework provides a set of APIs for the PHY drivers to
>> create/destroy a PHY and APIs for the PHY users to obtain a reference
>> to the PHY with or without using phandle. For dt-boot, the PHY drivers
>> should also register *PHY provider* with the framework.
>>
>> PHY drivers should create the PHY by passing id and ops like init, exit,
>> power_on and power_off. This framework is also pm runtime enabled.
>>
>> The documentation for the generic PHY framework is added in
>> Documentation/phy.txt and the documentation for dt binding can be found
>> at Documentation/devicetree/bindings/phy/phy-bindings.txt
>>
>> Cc: Tomasz Figa <t.figa@samsung•com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti•com>
>> Acked-by: Felipe Balbi <balbi@ti•com>
>> Tested-by: Sylwester Nawrocki <s.nawrocki@samsung•com>
>> ---
>> .../devicetree/bindings/phy/phy-bindings.txt | 66 ++
>> Documentation/phy.txt | 166 +++++
>> MAINTAINERS | 8 +
>> drivers/Kconfig | 2 +
>> drivers/Makefile | 2 +
>> drivers/phy/Kconfig | 18 +
>> drivers/phy/Makefile | 5 +
>> drivers/phy/phy-core.c | 714
>> ++++++++++++++++++++
>> include/linux/phy/phy.h | 270 ++++++++
>> 9 files changed, 1251 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/phy-
>> bindings.txt
>> create mode 100644 Documentation/phy.txt create mode 100644
>> drivers/phy/Kconfig create mode 100644 drivers/phy/Makefile create
>> mode 100644 drivers/phy/phy-core.c create mode 100644
>> include/linux/phy/phy.h
>>
>
> [snip]
>
>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h new file
>> mode 100644 index 0000000..e444b23
>> --- /dev/null
>> +++ b/include/linux/phy/phy.h
>> @@ -0,0 +1,270 @@
>
> [snip]
>
>> +struct phy_init_data {
>> + unsigned int num_consumers;
>> + struct phy_consumer *consumers;
>> +};
>> +
>> +#define PHY_CONSUMER(_dev_name, _port) \
>> +{ \
>> + .dev_name = _dev_name, \
>> + .port = _port, \
>> +}
>> +
>> +#define to_phy(dev) (container_of((dev), struct phy, dev))
>> +
>> +#define of_phy_provider_register(dev, xlate) \
>> + __of_phy_provider_register((dev), THIS_MODULE, (xlate))
>> +
>> +#define devm_of_phy_provider_register(dev, xlate) \
>> + __of_phy_provider_register((dev), THIS_MODULE, (xlate))
>
> I think this should be:
> + __devm_of_phy_provider_register((dev), THIS_MODULE, (xlate))
> Right?
right.. thanks for spotting this.
Regards
Kishon
next prev parent reply other threads:[~2013-07-29 15:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 12:49 [RESEND PATCH v10 0/8] PHY framework Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 1/8] drivers: phy: add generic " Kishon Vijay Abraham I
2013-07-29 15:28 ` Kamil Debski
2013-07-29 15:30 ` Kishon Vijay Abraham I [this message]
2013-07-29 15:51 ` Sylwester Nawrocki
2013-07-30 5:12 ` Kishon Vijay Abraham I
2013-08-01 1:40 ` Greg KH
2013-07-26 12:49 ` [RESEND PATCH v10 2/8] usb: phy: omap-usb2: use the new " Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 3/8] usb: phy: twl4030: " Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 4/8] arm: omap3: twl: add phy consumer data in twl4030_usb_data Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 5/8] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 6/8] usb: musb: omap2430: use the new generic PHY framework Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 7/8] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 8/8] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F68AB2.5090402@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox