From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 7/8] ARM: tegra114: add LP1 suspend support
Date: Mon, 29 Jul 2013 17:53:35 -0600 [thread overview]
Message-ID: <51F7007F.6090200@wwwdotorg.org> (raw)
In-Reply-To: <1374830110-30685-8-git-send-email-josephl@nvidia.com>
On 07/26/2013 03:15 AM, Joseph Lo wrote:
> The LP1 suspend mode will power off the CPU, clock gated the PLLs and put
> SDRAM to self-refresh mode. Any interrupt can wake up device from LP1. The
> sequence when LP1 suspending:
> diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c
> index 5ae7ee5..36cadaa 100644
> --- a/arch/arm/mach-tegra/pm.c
> +++ b/arch/arm/mach-tegra/pm.c
> @@ -214,6 +214,7 @@ static bool tegra_lp1_iram_hook(void)
> tegra20_lp1_iram_hook();
> break;
> case TEGRA30:
> + case TEGRA114:
> tegra30_lp1_iram_hook();
That's in pm-tegra30.c, which is only compiled in if
CONFIG_ARCH_TEGRA_3x_SOC is enabled. Similarly, this patch adds a lot of
code to sleep-tegra30.S, which also isn't built/linked if
!CONFIG_ARCH_TEGRA_3x_SOC.
Does this series built with all 7 combinations of Tegra20/30/114 support
enabled?
> diff --git a/arch/arm/mach-tegra/sleep-tegra30.S b/arch/arm/mach-tegra/sleep-tegra30.S
> @@ -96,9 +100,15 @@
> orreq \rd, \rd, #(1 << 30)
> streq \rd, [\r_car_base, #\pll_base]
> /* Enable lock detector */
> + .if \pll_misc
> + ldr \rd, [\r_car_base, #\pll_misc]
> + bic \rd, \rd, #(1 << 18)
> + str \rd, [\r_car_base, #\pll_misc]
> + ldr \rd, [\r_car_base, #\pll_misc]
> ldr \rd, [\r_car_base, #\pll_misc]
> orr \rd, \rd, #(1 << 18)
> str \rd, [\r_car_base, #\pll_misc]
> + .endif
Hmm. Those last 3 lines that aren't touched by this patch already
touched the pll_misc register even if !pll_misc. Was that a bug in a
previous patch?
Is git bisect maintained for both compile and run-time across this whole
patch series?
next prev parent reply other threads:[~2013-07-29 23:53 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 9:15 [PATCH 0/8] ARM: tegra: support LP1 suspend mode Joseph Lo
2013-07-26 9:15 ` [PATCH 1/8] ARM: tegra: add common resume handling code for LP1 resuming Joseph Lo
2013-07-29 22:38 ` Stephen Warren
2013-07-26 9:15 ` [PATCH 2/8] ARM: tegra: config the polarity of the request of sys clock Joseph Lo
2013-07-29 22:47 ` Stephen Warren
2013-08-02 7:48 ` Joseph Lo
2013-08-02 20:24 ` Stephen Warren
2013-08-05 8:42 ` Joseph Lo
2013-07-26 9:15 ` [PATCH 3/8] clk: tegra114: add LP1 suspend/resume support Joseph Lo
2013-07-29 22:51 ` Stephen Warren
2013-08-02 8:09 ` Joseph Lo
2013-08-02 20:32 ` Stephen Warren
2013-08-05 8:02 ` Joseph Lo
2013-08-05 17:00 ` Stephen Warren
2013-08-05 17:39 ` Stephen Warren
2013-08-06 9:10 ` Joseph Lo
2013-08-06 18:37 ` Stephen Warren
2013-08-07 9:12 ` Joseph Lo
2013-08-07 16:46 ` Stephen Warren
2013-08-08 2:23 ` Joseph Lo
2013-08-08 19:54 ` Stephen Warren
2013-08-09 9:23 ` Joseph Lo
2013-08-06 9:19 ` Joseph Lo
2013-07-26 9:15 ` [PATCH 4/8] ARM: tegra: add common LP1 suspend support Joseph Lo
2013-07-29 23:13 ` Stephen Warren
2013-08-02 9:27 ` Joseph Lo
2013-08-02 20:40 ` Stephen Warren
2013-08-05 8:07 ` Joseph Lo
2013-07-26 9:15 ` [PATCH 5/8] ARM: tegra30: add " Joseph Lo
2013-07-29 23:45 ` Stephen Warren
2013-08-05 6:46 ` Joseph Lo
2013-07-26 9:15 ` [PATCH 6/8] ARM: tegra20: " Joseph Lo
2013-07-26 9:15 ` [PATCH 7/8] ARM: tegra114: " Joseph Lo
2013-07-29 23:53 ` Stephen Warren [this message]
2013-08-05 6:51 ` Joseph Lo
2013-07-26 9:15 ` [PATCH 8/8] ARM: dts: tegra: enable LP1 suspend mode Joseph Lo
2013-07-27 16:12 ` [PATCH 0/8] ARM: tegra: support " Marc Dietrich
2013-07-27 16:20 ` Dmitry Osipenko
2013-07-27 18:09 ` Marc Dietrich
2013-07-27 18:26 ` Dmitry Osipenko
2013-07-27 18:29 ` Dmitry Osipenko
2013-07-27 19:03 ` Marc Dietrich
2013-07-27 19:11 ` Dmitry Osipenko
2013-07-30 9:49 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F7007F.6090200@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox