public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: t-kristo@ti•com (Tero Kristo)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv4 08/33] ARM: dts: omap4 clock data
Date: Wed, 31 Jul 2013 17:49:28 +0300	[thread overview]
Message-ID: <51F923F8.6080700@ti.com> (raw)
In-Reply-To: <51F813B3.7020000@ti.com>

On 07/30/2013 10:27 PM, Nishanth Menon wrote:
> On 07/23/2013 02:20 AM, Tero Kristo wrote:
>> This patch creates a unique node for each clock in the OMAP4 power,
>> reset and clock manager (PRCM). OMAP443x and OMAP446x have slightly
>> different clock tree which is taken into account in the data.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti•com>
>> ---
>>   arch/arm/boot/dts/omap443x-clocks.dtsi |   17 +
>>   arch/arm/boot/dts/omap443x.dtsi        |    8 +
>>   arch/arm/boot/dts/omap4460.dtsi        |    8 +
>>   arch/arm/boot/dts/omap446x-clocks.dtsi |   27 +
>>   arch/arm/boot/dts/omap44xx-clocks.dtsi | 1654
>> ++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/omap44xx-common-clocks.dtsi ?
>>   5 files changed, 1714 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/omap443x-clocks.dtsi
>>   create mode 100644 arch/arm/boot/dts/omap446x-clocks.dtsi
>>   create mode 100644 arch/arm/boot/dts/omap44xx-clocks.dtsi
>>
>> diff --git a/arch/arm/boot/dts/omap443x-clocks.dtsi
>> b/arch/arm/boot/dts/omap443x-clocks.dtsi
>> new file mode 100644
>> index 0000000..2bd82b2
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/omap443x-clocks.dtsi
>> @@ -0,0 +1,17 @@
>> +/*
>> + * Device Tree Source for OMAP443x clock data
>> + *
>> + * Copyright (C) 2013 Texas Instruments, Inc.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
> Doing
> /include/ "omap44xx-clocks.dtsi" might avoid including that header in
> corresponding SoC dtsi,
> OR:
>> +bandgap_fclk: bandgap_fclk at 4a307888 {
>> +    #clock-cells = <0>;
>> +    compatible = "gate-clock";
>> +    clocks = <&sys_32k_ck>;
>> +    bit-shift = <8>;
>> +    reg = <0x4a307888 0x4>;
>> +};
>
> Since we already have omap443x.dtsi and omap446x.dtsi, do we need
> clock.dtsi containing just a few entries?
> instead we could define the delta clocks in the clocks section, and save
> on two additional files, no?

Yea, thats also possible. I didn't want to put clock nodes there though, 
just for clarity. I think this is for whoever is maintaining the DTS 
files to answer.

>
> [...]
>
>> diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi
>> b/arch/arm/boot/dts/omap44xx-clocks.dtsi
>> new file mode 100644
>> index 0000000..ed6bc9b
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi
> [...]
>
>> +dpll_abe_m2x2_ck: dpll_abe_m2x2_ck at 4a0041f0 {
>> +    #clock-cells = <0>;
>> +    compatible = "divider-clock";
>> +    clocks = <&dpll_abe_x2_ck>;
>> +    ti,autoidle-shift = <8>;
>> +    reg = <0x4a0041f0 0x4>;
>> +    bit-mask = <0x1f>;
>> +    index-starts-at-one;
>> +    ti,autoidle-low;
>> +};
>> +
>> +abe_24m_fclk: abe_24m_fclk {
>> +    #clock-cells = <0>;
>> +    compatible = "fixed-factor-clock";
>> +    clocks = <&dpll_abe_m2x2_ck>;
>> +    clock-mult = <1>;
>> +    clock-div = <8>;
>> +};
>> +
>> +abe_clk: abe_clk at 4a004108 {
>> +    #clock-cells = <0>;
>> +    compatible = "divider-clock";
>> +    clocks = <&dpll_abe_m2x2_ck>;
>> +    reg = <0x4a004108 0x4>;
>> +    bit-mask = <0x3>;
>> +    index-power-of-two;
>> +};
>> +
>> +aess_fclk: aess_fclk at 4a004528 {
> is there a naming convention used here? abe_clk, fclk etc?

The clock names are directly converted from existing data, so whatever 
currently is there, will be in the DT also.

>
>> +    #clock-cells = <0>;
>> +    compatible = "divider-clock";
>> +    clocks = <&abe_clk>;
>> +    bit-shift = <24>;
>> +    reg = <0x4a004528 0x4>;
>> +    bit-mask = <0x1>;
>> +};
>
> [...]
>
>> +
>> +ocp2scp_usb_phy_phy_48m: ocp2scp_usb_phy_phy_48m at 4a0093e0 {
> _ck?
>
> [...]
>
>

  reply	other threads:[~2013-07-31 14:49 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  7:19 [PATCHv4 00/33] ARM: OMAP: clock conversion to DT Tero Kristo
2013-07-23  7:19 ` [PATCHv4 01/33] CLK: clkdev: add support for looking up clocks from DT Tero Kristo
2013-07-30 15:04   ` Nishanth Menon
2013-07-31  8:43     ` Tero Kristo
2013-07-23  7:19 ` [PATCHv4 02/33] clk: omap: introduce clock driver Tero Kristo
2013-07-30 15:21   ` Nishanth Menon
2013-07-31  8:59     ` Tero Kristo
2013-08-01 13:44       ` Nishanth Menon
2013-08-01 14:59         ` Tero Kristo
2013-07-23  7:19 ` [PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support Tero Kristo
2013-07-30 16:23   ` Nishanth Menon
2013-07-31  9:46     ` Tero Kristo
2013-08-01 14:00       ` Nishanth Menon
2013-08-01 15:08         ` Tero Kristo
2013-08-01 15:13           ` Nishanth Menon
2013-08-01  8:29   ` Rajendra Nayak
2013-08-01 15:10     ` Nishanth Menon
2013-08-01 15:41       ` Tero Kristo
2013-07-23  7:19 ` [PATCHv4 04/33] CLK: omap: move part of the machine specific clock header contents to driver Tero Kristo
2013-07-30 18:22   ` Nishanth Menon
2013-07-31  9:59     ` Tero Kristo
2013-08-01 14:04       ` Nishanth Menon
2013-08-01 15:12         ` Tero Kristo
2013-08-01 15:21           ` Nishanth Menon
2013-07-23  7:20 ` [PATCHv4 05/33] CLK: omap: add DT duplicate clock registration mechanism Tero Kristo
2013-07-30 18:40   ` Nishanth Menon
2013-07-31 10:07     ` Tero Kristo
2013-08-01 14:25       ` Nishanth Menon
2013-08-01 15:18         ` Tero Kristo
2013-08-01 15:24           ` Nishanth Menon
2013-08-01 15:30             ` Tero Kristo
2013-08-02  7:22               ` Tony Lindgren
2013-07-23  7:20 ` [PATCHv4 06/33] CLK: omap: add autoidle support Tero Kristo
2013-07-30 18:56   ` Nishanth Menon
2013-07-31 10:13     ` Tero Kristo
2013-08-01 14:11       ` Nishanth Menon
2013-08-01 15:22         ` Tero Kristo
2013-07-23  7:20 ` [PATCHv4 07/33] CLK: omap: add support for OMAP gate clock Tero Kristo
2013-07-30 19:17   ` Nishanth Menon
2013-07-31 14:45     ` Tero Kristo
2013-08-01 14:33       ` Nishanth Menon
2013-08-01 15:29         ` Tero Kristo
2013-07-23  7:20 ` [PATCHv4 08/33] ARM: dts: omap4 clock data Tero Kristo
2013-07-30 19:27   ` Nishanth Menon
2013-07-31 14:49     ` Tero Kristo [this message]
2013-07-23  7:20 ` [PATCHv4 09/33] CLK: omap: add omap4 clock init file Tero Kristo
2013-07-30 19:33   ` Nishanth Menon
2013-07-31 14:52     ` Tero Kristo
2013-08-01 14:40       ` Nishanth Menon
2013-08-01 15:34         ` Tero Kristo
2013-08-01 16:10           ` Nishanth Menon
2013-07-23  7:20 ` [PATCHv4 10/33] ARM: OMAP4: remove old clock data and link in new clock init code Tero Kristo
2013-07-30 19:42   ` Nishanth Menon
2013-07-31 14:55     ` Tero Kristo
2013-07-23  7:20 ` [PATCHv4 11/33] ARM: dts: omap5 clock data Tero Kristo
2013-07-23  7:20 ` [PATCHv4 12/33] CLK: omap: add omap5 clock init file Tero Kristo
2013-07-23  7:20 ` [PATCHv4 13/33] ARM: dts: dra7 clock data Tero Kristo
2013-07-23  7:20 ` [PATCHv4 14/33] CLK: omap: add dra7 clock init file Tero Kristo
2013-07-23  7:20 ` [PATCHv4 15/33] CLK: OMAP: DPLL: add support for DT property ti, dpll-no-gate Tero Kristo
2013-07-30 19:18   ` [PATCHv4 15/33] CLK: OMAP: DPLL: add support for DT property ti,dpll-no-gate Nishanth Menon
2013-07-31 14:56     ` Tero Kristo
2013-07-23  7:20 ` [PATCHv4 16/33] CLK: OMAP: DPLL: do not of_iomap NULL autoidle register Tero Kristo
2013-07-30 19:49   ` Nishanth Menon
2013-07-31 14:57     ` Tero Kristo
2013-07-23  7:20 ` [PATCHv4 17/33] CLK: DT: add support for set-rate-parent flag Tero Kristo
2013-07-30 19:58   ` Nishanth Menon
2013-07-23  7:20 ` [PATCHv4 18/33] ARM: dts: am33xx clock data Tero Kristo
2013-07-23  7:20 ` [PATCHv4 19/33] CLK: omap: add am33xx clock init file Tero Kristo
2013-07-30 20:00   ` Nishanth Menon
2013-07-31 14:59     ` Tero Kristo
2013-08-01 14:43       ` Nishanth Menon
2013-08-01 15:35         ` Tero Kristo
2013-07-23  7:20 ` [PATCHv4 20/33] ARM: AM33xx: remove old clock data and link in new clock init code Tero Kristo
2013-07-23  7:20 ` [PATCHv4 21/33] CLK: OMAP: DPLL: add omap3 dpll support Tero Kristo
2013-07-30 20:08   ` Nishanth Menon
2013-07-31 15:03     ` Tero Kristo
2013-08-01 14:46       ` Nishanth Menon
2013-07-23  7:20 ` [PATCHv4 22/33] CLK: OMAP: update gate clock setup for OMAP3 Tero Kristo
2013-07-30 20:13   ` Nishanth Menon
2013-07-31 15:05     ` Tero Kristo
2013-07-23  7:20 ` [PATCHv4 23/33] CLK: OMAP: add interface clock support " Tero Kristo
2013-07-30 20:23   ` Nishanth Menon
2013-07-31 15:09     ` Tero Kristo
2013-08-01 14:50       ` Nishanth Menon
2013-07-23  7:20 ` [PATCHv4 24/33] CLK: OMAP: move some defines from machine to driver header Tero Kristo
2013-07-23  7:20 ` [PATCHv4 25/33] ARM: OMAP: hwmod: fix an incorrect clk type cast with _get_clkdm Tero Kristo
2013-07-23  7:20 ` [PATCHv4 26/33] CLK: omap: gate: add support for OMAP36xx dpllx_mx_ck:s Tero Kristo
2013-07-23  7:20 ` [PATCHv4 27/33] ARM: OMAP3: hwmod: initialize clkdm from clkdm_name Tero Kristo
2013-07-23  7:20 ` [PATCHv4 28/33] ARM: dts: omap3 clock data Tero Kristo
2013-07-23  7:20 ` [PATCHv4 30/33] clk: OMAP: DRA7: Add APLL support Tero Kristo
2013-07-23  7:20 ` [PATCHv4 31/33] ARM: dts: clk: Add apll related clocks Tero Kristo
2013-07-23  7:20 ` [PATCHv4 32/33] clk: OMAP: DRA7: Change apll_pcie_m2_ck to fixed factor clock Tero Kristo
2013-07-23  7:20 ` [PATCHv4 33/33] clk: DTS: DRA7: Add PCIe related clock nodes Tero Kristo
2013-07-23  8:24 ` [PATCHv4 00/33] ARM: OMAP: clock conversion to DT Tero Kristo
2013-07-24 14:16 ` Roger Quadros
2013-07-24 14:29   ` Tero Kristo
2013-07-24 14:34     ` Roger Quadros
2013-07-24 14:43       ` Tero Kristo
     [not found] ` <1374564028-11352-30-git-send-email-t-kristo@ti.com>
2013-07-30 20:19   ` [PATCHv4 29/33] CLK: omap: add omap3 clock init file Nishanth Menon
2013-07-31  6:35     ` Tony Lindgren
2013-07-31 15:10       ` Tero Kristo
2013-08-02  7:24         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F923F8.6080700@ti.com \
    --to=t-kristo@ti$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox