From: linux@roeck-us•net (Guenter Roeck)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v7] watchdog: Add MOXA ART watchdog driver
Date: Fri, 02 Aug 2013 09:39:49 -0700 [thread overview]
Message-ID: <51FBE0D5.3070007@roeck-us.net> (raw)
In-Reply-To: <20130802114159.GK2884@e106331-lin.cambridge.arm.com>
On 08/02/2013 04:41 AM, Mark Rutland wrote:
> On Mon, Jul 29, 2013 at 01:33:48PM +0100, Jonas Jensen wrote:
>> Add watchdog driver for MOXA ART SoCs.
>>
[ ... ]
>> +
>> + err = watchdog_register_device(&moxart_wdt->dev);
>> + if (unlikely(err))
>> + return err;
>
> This is a probe path. Is the use of unlikely() really appropriate here?
> I suspect it doesn't make any appreciable difference, and should go.
>
Just wondering, for my education - why ? Is there s rule that unlikely()
shall not be used in the probe path ? If so, I would like to know it and
its reasoning to be able to apply it to my own reviews.
Thanks,
Guenter
next prev parent reply other threads:[~2013-08-02 16:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 12:29 [PATCH] watchdog: Add MOXA ART watchdog driver Jonas Jensen
2013-07-11 16:35 ` Guenter Roeck
2013-07-16 13:24 ` [PATCH v2] " Jonas Jensen
2013-07-17 9:24 ` [PATCH v3] " Jonas Jensen
2013-07-18 23:05 ` Guenter Roeck
2013-07-19 10:23 ` [PATCH v4] " Jonas Jensen
2013-07-20 16:40 ` Arnd Bergmann
2013-07-21 7:33 ` Guenter Roeck
2013-07-29 10:20 ` [PATCH v5] " Jonas Jensen
2013-07-29 11:05 ` Guenter Roeck
2013-07-29 11:41 ` [PATCH v6] " Jonas Jensen
2013-07-29 11:57 ` Guenter Roeck
2013-07-29 12:33 ` [PATCH v7] " Jonas Jensen
2013-07-29 22:18 ` Guenter Roeck
2013-08-02 11:41 ` Mark Rutland
2013-08-02 14:55 ` Jonas Jensen
2013-08-02 16:39 ` Guenter Roeck [this message]
2013-08-05 10:12 ` Mark Rutland
2013-08-02 14:40 ` [PATCH v8] " Jonas Jensen
2013-08-02 23:58 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FBE0D5.3070007@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox