From: josh.wu@atmel•com (Josh Wu)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 6/6] mtd: ofpart: add compatible check for child nodes
Date: Mon, 5 Aug 2013 19:33:36 +0800 [thread overview]
Message-ID: <51FF8D90.2060308@atmel.com> (raw)
In-Reply-To: <1375701279-11495-7-git-send-email-josh.wu@atmel.com>
Add device tree mail list to CC.
On 8/5/2013 7:14 PM, Josh Wu wrote:
> In case that the nand device will support some features like Nand Flash
> Controller, we want to make the sub feature as a sub node of nand device.
>
> Use such organization it is easy to enable/disable feature, also it is back
> compatible and more readable.
>
> If the sub-node has a compatible property then it is a driver not partition.
>
> Signed-off-by: Josh Wu <josh.wu@atmel•com>
> Acked-by: Brian Norris <computersforpeace@gmail•com>
> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
> ---
> v3 --> v4:
> - remove the 'len' parameter, just use NULL.
> - refine the commit message.
> - also add a NOTE in devicetree/bindings/mtd/partition.txt.
>
> .../devicetree/bindings/mtd/partition.txt | 1 +
> drivers/mtd/ofpart.c | 13 ++++++++++++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/partition.txt b/Documentation/devicetree/bindings/mtd/partition.txt
> index 9315ac9..8e5557d 100644
> --- a/Documentation/devicetree/bindings/mtd/partition.txt
> +++ b/Documentation/devicetree/bindings/mtd/partition.txt
> @@ -4,6 +4,7 @@ Partitions can be represented by sub-nodes of an mtd device. This can be used
> on platforms which have strong conventions about which portions of a flash are
> used for what purposes, but which don't use an on-flash partition table such
> as RedBoot.
> +NOTE: if the sub-node has a compatible string, then it is not a partition.
>
> #address-cells & #size-cells must both be present in the mtd device. There are
> two valid values for both:
> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
> index 553d6d6..30fcea1 100644
> --- a/drivers/mtd/ofpart.c
> +++ b/drivers/mtd/ofpart.c
> @@ -20,6 +20,10 @@
> #include <linux/slab.h>
> #include <linux/mtd/partitions.h>
>
> +static bool node_has_compatible(struct device_node *pp)
> +{
> + return of_get_property(pp, "compatible", NULL);
> +}
> static int parse_ofpart_partitions(struct mtd_info *master,
> struct mtd_partition **pparts,
> struct mtd_part_parser_data *data)
> @@ -40,8 +44,12 @@ static int parse_ofpart_partitions(struct mtd_info *master,
> /* First count the subnodes */
> pp = NULL;
> nr_parts = 0;
> - while ((pp = of_get_next_child(node, pp)))
> + while ((pp = of_get_next_child(node, pp))) {
> + if (node_has_compatible(pp))
> + continue;
> +
> nr_parts++;
> + }
>
> if (nr_parts == 0)
> return 0;
> @@ -57,6 +65,9 @@ static int parse_ofpart_partitions(struct mtd_info *master,
> int len;
> int a_cells, s_cells;
>
> + if (node_has_compatible(pp))
> + continue;
> +
> reg = of_get_property(pp, "reg", &len);
> if (!reg) {
> nr_parts--;
next prev parent reply other threads:[~2013-08-05 11:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 11:14 [PATCH v6 0/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Josh Wu
2013-08-05 11:14 ` [PATCH 1/6] MTD: atmel_nand: use devm_xxx gpio kzalloc, gpio and ioremap Josh Wu
2013-08-05 13:04 ` Artem Bityutskiy
2013-08-05 11:14 ` [PATCH 2/6] mtd: atmel_nand: replace pmecc enable code with one function Josh Wu
2013-08-07 7:20 ` Brian Norris
2013-08-07 9:20 ` Josh Wu
2013-08-05 11:14 ` [PATCH 3/6] mtd: atmel_nand: add Nand Flash Controller (NFC) support Josh Wu
2013-08-05 11:14 ` [PATCH 4/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) read data via sram Josh Wu
2013-08-05 11:14 ` [PATCH 5/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) write " Josh Wu
2013-08-05 11:14 ` [PATCH 6/6] mtd: ofpart: add compatible check for child nodes Josh Wu
2013-08-05 11:33 ` Josh Wu [this message]
2013-08-05 18:56 ` Brian Norris
-- strict thread matches above, loose matches on Subject: below --
2013-07-03 9:50 [PATCH v5 0/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Josh Wu
2013-07-03 9:50 ` [PATCH 6/6] mtd: ofpart: add compatible check for child nodes Josh Wu
2013-07-18 7:14 ` Brian Norris
2013-07-18 8:28 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-19 6:23 [PATCH v4 0/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Josh Wu
2013-06-19 6:23 ` [PATCH 6/6] mtd: ofpart: add compatible check for child nodes Josh Wu
2013-06-10 10:26 [PATCH v3 0/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Josh Wu
2013-06-10 10:26 ` [PATCH 6/6] mtd: ofpart: add compatible check for child nodes Josh Wu
2013-06-10 12:35 ` Sergei Shtylyov
2013-06-13 3:42 ` Josh Wu
2013-06-13 13:13 ` Sergei Shtylyov
2013-06-11 23:34 ` Brian Norris
2013-06-13 3:38 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FF8D90.2060308@atmel.com \
--to=josh.wu@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox