From: Yushan Wang <wangyushan12@huawei•com>
To: Ian Rogers <irogers@google•com>
Cc: <peterz@infradead•org>, <mingo@redhat•com>, <acme@kernel•org>,
<namhyung@kernel•org>, <mark.rutland@arm•com>,
<alexander.shishkin@linux•intel.com>, <jolsa@kernel•org>,
<adrian.hunter@intel•com>, <james.clark@arm•com>,
<john.g.garry@oracle•com>, <will@kernel•org>,
<mike.leach@arm•com>, <linux-perf-users@vger•kernel.org>,
<linux-kernel@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>, <jic23@kernel•org>,
<leo.yan@linux•dev>, <robin.murphy@arm•com>,
<linuxarm@huawei•com>, <hejunhao3@huawei•com>,
<prime.zeng@hisilicon•com>, <fanghao11@huawei•com>,
<wangzhou1@hisilicon•com>
Subject: Re: [RFT PATCH v2 4/7] perf-x86: iostat: Change iostat_prefix() to static
Date: Fri, 8 May 2026 18:35:38 +0800 [thread overview]
Message-ID: <51c6ea87-7812-4be2-ae1d-0fca29973623@huawei.com> (raw)
In-Reply-To: <CAP-5=fUVf-6Xcd+xQBm9FbwbWsUff0PYuH54mrBkLeVyU2cj8Q@mail.gmail.com>
On 5/7/2026 11:39 PM, Ian Rogers wrote:
> On Wed, May 6, 2026 at 11:37 PM Yushan Wang <wangyushan12@huawei•com> wrote:
>>
>> Change iostat_prefix() to static function, since it is not used outside.
>>
>> Signed-off-by: Yushan Wang <wangyushan12@huawei•com>
>
> Reviewed-by: Ian Rogers <irogers@google•com>
>
>> ---
>> tools/perf/util/iostat.c | 7 ------
>> tools/perf/util/iostat.h | 2 --
>> tools/perf/util/x86-iostat.c | 44 ++++++++++++++++++------------------
>> 3 files changed, 22 insertions(+), 31 deletions(-)
>>
>> diff --git a/tools/perf/util/iostat.c b/tools/perf/util/iostat.c
>> index b770bd473af7..a68ab100780d 100644
>> --- a/tools/perf/util/iostat.c
>> +++ b/tools/perf/util/iostat.c
>> @@ -37,13 +37,6 @@ __weak void iostat_print_metric(struct perf_stat_config *config __maybe_unused,
>> {
>> }
>>
>> -__weak void iostat_prefix(struct evlist *evlist __maybe_unused,
>> - struct perf_stat_config *config __maybe_unused,
>> - char *prefix __maybe_unused,
>> - struct timespec *ts __maybe_unused)
>> -{
>> -}
>> -
>> __weak void iostat_print_counters(struct evlist *evlist __maybe_unused,
>> struct perf_stat_config *config __maybe_unused,
>> struct timespec *ts __maybe_unused,
>
> This change doesn't remove the weak symbols, but they should go. We
> should use the ELF machine to determine which architecture version to
> use.
The weak symbols are removed in patch 6. Reserving them here keeps this patch
from failing perf build :)
Thanks,
Yushan
>
> Thanks,
> Ian
>
[...]
next prev parent reply other threads:[~2026-05-08 10:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 6:37 [RFT PATCH v2 0/7] perf tool: Support iostat for multiple platform Yushan Wang
2026-05-07 6:37 ` [RFT PATCH v2 1/7] perf stat: Check color's length instead of the pointer Yushan Wang
2026-05-07 15:33 ` Ian Rogers
2026-05-07 6:37 ` [RFT PATCH v2 2/7] perf stat: Save unnecessary print_metric() call Yushan Wang
2026-05-07 15:30 ` Ian Rogers
2026-05-07 6:37 ` [RFT PATCH v2 3/7] perf-x86: iostat: Move iostat arch-specific implementation to util Yushan Wang
2026-05-07 15:35 ` Ian Rogers
2026-05-08 10:34 ` Yushan Wang
2026-05-07 6:37 ` [RFT PATCH v2 4/7] perf-x86: iostat: Change iostat_prefix() to static Yushan Wang
2026-05-07 15:39 ` Ian Rogers
2026-05-08 10:35 ` Yushan Wang [this message]
2026-05-07 6:37 ` [RFT PATCH v2 5/7] perf-iostat: Extend iostat interface to support different iostat PMUs Yushan Wang
2026-05-07 15:47 ` Ian Rogers
2026-05-08 10:36 ` Yushan Wang
2026-05-07 6:37 ` [RFT PATCH v2 6/7] perf-iostat: Make x86 iostat compatible with new iostat framework Yushan Wang
2026-05-07 16:17 ` Ian Rogers
2026-05-08 10:36 ` Yushan Wang
2026-05-07 6:37 ` [RFT PATCH v2 7/7] perf-iostat: Enable iostat mode for HiSilicon PCIe PMU Yushan Wang
2026-05-07 16:20 ` Ian Rogers
2026-05-08 10:36 ` Yushan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51c6ea87-7812-4be2-ae1d-0fca29973623@huawei.com \
--to=wangyushan12@huawei$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=fanghao11@huawei$(echo .)com \
--cc=hejunhao3@huawei$(echo .)com \
--cc=irogers@google$(echo .)com \
--cc=james.clark@arm$(echo .)com \
--cc=jic23@kernel$(echo .)org \
--cc=john.g.garry@oracle$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=leo.yan@linux$(echo .)dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linuxarm@huawei$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mike.leach@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=prime.zeng@hisilicon$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=wangzhou1@hisilicon$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox