Subject: [PATCH] mach-ks8695/Kconfig: Make MACH_KS8695 depends on PCI

From: [email-masked] (Greg Ungerer)
Date: Tue, 06 Aug 2013 12:07:02 +1000

Hi Manjunath,

On 05/08/13 20:31, Manjunath Goudar wrote:
> On 5 August 2013 14:47, Viresh Kumar <viresh.kumar at linaro.org <mailto:[email-masked]>> wrote:
> 
>     On 5 August 2013 14:37, Manjunath Goudar <manjunath.goudar at linaro.org <mailto:[email-masked]>> wrote:
>     > From: root <root at si-cspbld63.lge.net <mailto:[email-masked]>>
> 
>     :)
> 
>     > This patch adds a Kconfig dependency on MACH_KS8695,MACH_CM* or MACH_IM*
>     > being available before PCI can be enabled. Without this patch,build system
> 
>     Add Space after ','
> 
>     > can lead to issues. This was discovered during randconfig testing,
>     > without PCI if any one of MACH_KS8695,MACH_CM* or MACH_IM* being enabled,
> 
>     Same here.
> 
>     > leading to the following error:
>     >
>     > LD      init/built-in.o
>     > arch/arm/mach-ks8695/built-in.o: In function `og_register_pci':
>     > arch/arm/mach-ks8695/board-og.c:47:undefined reference to `ks8695_init_pci'
>     > make: *** [vmlinux] Error 1
>     >
>     > Signed-off-by: Manjunath Goudar <manjunath.goudar at linaro.org <mailto:[email-masked]>>
>     > Cc: Arnd Bergmann <arnd at arndb.de <mailto:[email-masked]>>
>     > Cc: Deepak Saxena <dsaxena at linaro.org <mailto:[email-masked]>>
>     > Cc: Greg Ungerer <gerg at uclinux.org <mailto:[email-masked]>>
>     > Cc: linux-arm-kernel at lists.infradead.org <mailto:[email-masked]>
>     > ---
>     >  arch/arm/mach-ks8695/Kconfig | 5 +++++
>     >  1 file changed, 5 insertions(+)
>     >
>     > diff --git a/arch/arm/mach-ks8695/Kconfig b/arch/arm/mach-ks8695/Kconfig
>     > index a545976..29d7d9f 100644
>     > --- a/arch/arm/mach-ks8695/Kconfig
>     > +++ b/arch/arm/mach-ks8695/Kconfig
>     > @@ -5,6 +5,7 @@ menu "Kendin/Micrel KS8695 Implementations"
>     >  config MACH_KS8695
>     >         bool "KS8695 development board"
>     >         select MIGHT_HAVE_PCI
>     > +       depends on PCI
> 
>     You need both PCI and MIGHT_HAVE_PCI? Don't know but it looks
>     like defconfig is missing PCI stuff.. and MIGHT_HAVE_PCI is enough
>     here?
> 
> 
>  PCI is needed here because board-og.c file depends on pci.o.

It shouldn't though, thus the original use of MIGHT_HAVE_PCI.
The board-og.c machine code supports a number of boards, some of
which don't have a PCI bus (that is they use the KS8695 CPU that
doesn't contain the PCI bus silicon).

I think you want a fix that makes the pci support code in this file
conditional on CONFIG_PCI.

Regards
Greg