From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support
Date: Tue, 06 Aug 2013 14:05:24 +0200 [thread overview]
Message-ID: <5200E684.5080003@free-electrons.com> (raw)
In-Reply-To: <20130716080503.GA3125@lukather>
On 16/07/2013 10:05, Maxime Ripard wrote:
> Hi Gregory,
>
> On Mon, Jul 15, 2013 at 04:24:36PM +0200, Gregory CLEMENT wrote:
>> The I2C Transaction Generator offloads CPU from managing I2C transfer step by step.
>>
>> This feature is currently only available on Armada XP, so usage of this mechanism is activated through device tree.
>>
>> Based on the work of Piotr Ziecik and rewrote to use the new way of handling multiples i2c messages.
>>
>> Signed-off-by: Piotr Ziecik <kosmo@semihalf•com> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com> --- drivers/i2c/busses/i2c-mv64xxx.c | 207
>> ++++++++++++++++++++++++++++++++++++--- 1 file changed, 196 insertions(+), 11 deletions(-)
>
> [...]
>
>> + /* + * For controllers embedded in new SoCs activate the + * Transaction Generator support. + */ + if (of_device_is_compatible(np, "marvell,mv78230-i2c")) +
>> drv_data->offload_enabled = true; +
>
> Do you have a reason for not adding it to the match table? I mean, you will introduce a new compatible here, but if that compatible is used alone, won't probe the driver? That doesn't
> seem very right to me.
But we shouldn't use it alone: we should always use:
compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
>From my point of view using "marvell,mv78230-i2c" alone is an error.
Wolfram what is your opinion on it?
>
> Also, you should probably add it to the bindings documentation.
See the patch 3 for the bindings documentation.
>
> Maxime
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-08-06 12:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 14:24 [PATCH 0/3] i2c-mv64xxx: Fixes and new feature for controlers embedded in Aramda XP Gregory CLEMENT
2013-07-15 14:24 ` [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support Gregory CLEMENT
2013-07-16 8:05 ` Maxime Ripard
2013-08-06 12:05 ` Gregory CLEMENT [this message]
2013-08-06 16:21 ` Maxime Ripard
2013-08-06 17:55 ` Thomas Petazzoni
2013-08-07 14:35 ` Wolfram Sang
2013-08-07 15:57 ` Jason Cooper
2013-08-08 15:30 ` Gregory CLEMENT
2013-08-08 16:43 ` Mark Rutland
2013-08-08 17:02 ` Jason Cooper
2013-08-08 17:09 ` Mark Rutland
2013-08-08 17:17 ` Jason Cooper
2013-08-09 13:22 ` Wolfram Sang
2013-07-15 14:24 ` [PATCH 2/3] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889) Gregory CLEMENT
2013-07-15 14:24 ` [PATCH 3/3] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c Gregory CLEMENT
2013-08-03 17:36 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5200E684.5080003@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox