From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/3] hwmon: (lm90) Add power control
Date: Thu, 08 Aug 2013 11:33:13 -0600 [thread overview]
Message-ID: <5203D659.4050907@wwwdotorg.org> (raw)
In-Reply-To: <52037F9A.7070802@roeck-us.net>
On 08/08/2013 05:23 AM, Guenter Roeck wrote:
> On 08/08/2013 02:47 AM, Wei Ni wrote:
...
>> I think get_regulator() will return error values, not only
>> -EPROBE_DEFER, so we should set data->lm90_reg to NULL to handle other
>> error values.
>>
> Matter of opinion if you want to check for IS_ERR or NULL later on.
No, if regulator returns either:
* Something valid
* Someting IS_ERR()
... then everywhere has to check the value using IS_ERR().
If regulator returns either:
* Something valid
* Someting NULL
... then everywhere has to check the value against NULL.
checking against both IS_ERR() and NULL shouldn't ever happen, and
likewise IS_ERR_OR_NULL() is deprecated.
next prev parent reply other threads:[~2013-08-08 17:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 6:56 [PATCH v2 0/3] Add power control for lm90 Wei Ni
2013-08-08 6:56 ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-08 7:13 ` Alexander Shiyan
2013-08-08 9:26 ` Wei Ni
2013-08-08 8:42 ` Guenter Roeck
2013-08-08 9:47 ` Wei Ni
2013-08-08 9:57 ` Alexander Shiyan
2013-08-08 9:59 ` Wei Ni
2013-08-08 10:07 ` Wei Ni
2013-08-08 11:23 ` Guenter Roeck
2013-08-08 17:33 ` Stephen Warren [this message]
2013-08-08 17:59 ` Guenter Roeck
2013-08-08 18:45 ` Stephen Warren
2013-08-08 17:30 ` Stephen Warren
2013-08-08 17:59 ` Guenter Roeck
2013-08-08 19:27 ` Mark Brown
2013-08-08 11:01 ` Mark Brown
2013-08-08 11:25 ` Guenter Roeck
2013-08-08 13:08 ` Mark Brown
2013-08-08 15:21 ` Guenter Roeck
2013-08-08 17:15 ` Mark Brown
2013-08-08 20:00 ` Guenter Roeck
2013-08-08 21:18 ` Mark Brown
2013-08-08 21:30 ` Guenter Roeck
[not found] ` <1376027820.695103970@f416.i.mail.ru>
2013-08-09 10:27 ` Proposal: I2C device power (Was: hwmon: (lm90) Add power control) Mark Brown
2013-08-09 10:50 ` Alexander Shiyan
2013-08-09 11:09 ` Mark Brown
2013-08-09 7:23 ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-09 10:56 ` Mark Brown
2013-08-08 6:56 ` [PATCH v2 2/3] ARM: dt: t114 dalmore: add dt entry for nct1008 Wei Ni
2013-08-08 17:35 ` Stephen Warren
2013-08-09 6:06 ` Wei Ni
2013-08-08 20:36 ` Sergei Shtylyov
2013-08-08 20:40 ` Stephen Warren
2013-08-08 21:33 ` Guenter Roeck
2013-08-09 6:16 ` Wei Ni
2013-08-08 6:56 ` [PATCH v2 3/3] Documentation: dt: hwmon: add OF document for lm90 Wei Ni
2013-08-08 17:37 ` Stephen Warren
2013-08-09 6:10 ` Wei Ni
2013-08-09 16:35 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203D659.4050907@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox