From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3] arm: omap5: dts: add palmas-usb node
Date: Mon, 12 Aug 2013 17:09:54 -0600 [thread overview]
Message-ID: <52096B42.60500@wwwdotorg.org> (raw)
In-Reply-To: <1376302675-15795-1-git-send-email-kishon@ti.com>
On 08/12/2013 04:17 AM, Kishon Vijay Abraham I wrote:
> From: Felipe Balbi <balbi@ti•com>
>
> Without this node, there will be no palmas
> driver to notify dwc3 that a cable has
> been connected and, without that, dwc3
> will never initialize.
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> interrupt-controller;
> #interrupt-cells = <2>;
>
> + extcon_usb3: palmas_usb {
> + compatible = "ti,palmas-usb";
This isn't so much a comment on this patch as the Palmas binding:
Presumably, the Palmas device contains a USB VID detector, not a whole
USB controller. I'd expect the compatible value to indicate this more
directly, i.e. be something like ti,palmas-usb-vid or
ti,palmas-usb-vid-detector.
next prev parent reply other threads:[~2013-08-12 23:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 12:50 [PATCH v2 0/5] ARM: OMAP: DTS/HWMOD/defconfig changes for USB3 Felipe Balbi
2013-07-16 12:50 ` [PATCH v2 1/5] arm: omap5: dts: fix reg property size Felipe Balbi
2013-07-16 12:50 ` [PATCH v2 2/5] arm: omap5: dts: fix ocp2scp DTS data Felipe Balbi
2013-07-16 12:50 ` [PATCH v2 3/5] arm: omap5: dts: add palmas-usb node Felipe Balbi
2013-07-16 12:50 ` [PATCH v2 4/5] arm: omap5: hwmod: add missing ocp2scp hwmod data Felipe Balbi
2013-07-16 12:50 ` [PATCH v2 5/5] arm: omap2plus_defconfig: enable dwc3 and dependencies Felipe Balbi
2013-08-21 12:53 ` Tony Lindgren
2013-08-12 10:17 ` [PATCH v3] arm: omap5: dts: add palmas-usb node Kishon Vijay Abraham I
2013-08-12 23:09 ` Stephen Warren [this message]
2013-08-13 5:37 ` [PATCH 1/2] extcon: palmas: Added a new compatible type *ti, palmas-usb-vid* Kishon Vijay Abraham I
2013-08-13 5:37 ` [PATCH v4 2/2] arm: omap5: dts: add palmas-usb node Kishon Vijay Abraham I
2013-08-13 9:54 ` [PATCH 1/2] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid* Chanwoo Choi
2013-08-13 9:58 ` [PATCH 1/2] extcon: palmas: Added a new compatible type *ti, palmas-usb-vid* Kishon Vijay Abraham I
2013-08-13 19:13 ` Stephen Warren
2013-08-14 5:24 ` Kishon Vijay Abraham I
2013-08-14 16:08 ` Stephen Warren
2013-08-15 16:09 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52096B42.60500@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox