From: Sudeep.KarkadaNagesha@arm•com (Sudeep KarkadaNagesha)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] irqchip: gic: fix boot for chained gics
Date: Tue, 13 Aug 2013 12:08:06 +0100 [thread overview]
Message-ID: <520A1396.6070400@arm.com> (raw)
In-Reply-To: <1371227097-3326-1-git-send-email-mark.rutland@arm.com>
On 14/06/13 17:24, Mark Rutland wrote:
> As of c0114709ed: "irqchip: gic: Perform the gic_secondary_init() call
> via CPU notifier", booting on a platform with chained gics (e.g.
> Realview EB ARM11MPCore) will result in the gic_cpu_notifier being
> registered twice, corrupting the cpu notifier list and rendering the
> platform unbootable.
Hi Mark,
This patch is still not in the mainline. I am unable to boot my Realview
EB ARM11MPCore without this patch.
Regards,
Sudeep
>
> This patch ensures that we only register the notifier for the first gic,
> allowing platforms with chained gics to boot. At the same time we limit
> the pointlessly duplicated calls to set_smp_cross_call and
> set_handle_irq to the first gic registered.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm•com>
> Cc: Catalin Marinas <catalin.marinas@arm•com>
> Cc: Thomas Gleixner <tglx@linutronix•de>
> ---
> drivers/irqchip/irq-gic.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> index 1760ceb..1a12bdf 100644
> --- a/drivers/irqchip/irq-gic.c
> +++ b/drivers/irqchip/irq-gic.c
> @@ -808,12 +808,13 @@ void __init gic_init_bases(unsigned int gic_nr, int irq_start,
> if (WARN_ON(!gic->domain))
> return;
>
> + if (gic_nr == 0) {
> #ifdef CONFIG_SMP
> - set_smp_cross_call(gic_raise_softirq);
> - register_cpu_notifier(&gic_cpu_notifier);
> + set_smp_cross_call(gic_raise_softirq);
> + register_cpu_notifier(&gic_cpu_notifier);
> #endif
> -
> - set_handle_irq(gic_handle_irq);
> + set_handle_irq(gic_handle_irq);
> + }
>
> gic_chip.flags |= gic_arch_extn.flags;
> gic_dist_init(gic);
>
prev parent reply other threads:[~2013-08-13 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 16:24 [PATCH] irqchip: gic: fix boot for chained gics Mark Rutland
2013-06-14 17:29 ` Catalin Marinas
2013-08-13 11:08 ` Sudeep KarkadaNagesha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A1396.6070400@arm.com \
--to=sudeep.karkadanagesha@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox