From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv3 3/5] arm64: read enable-method for CPU0
Date: Wed, 14 Aug 2013 14:15:55 -0400 [thread overview]
Message-ID: <520BC95B.6080307@ti.com> (raw)
In-Reply-To: <1376497228-20543-4-git-send-email-mark.rutland@arm.com>
On Wednesday 14 August 2013 12:20 PM, Mark Rutland wrote:
> With the advent of CPU_HOTPLUG, the enable-method property for CPU0
> may tells us something useful (i.e. how to hotplug it back on), so
> we must read it along with all the enable-method for all the other CPUs.
>
Can you please expand this a bit.
> This patch ensures that CPU0's enable-method property is read.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm•com>
> ---
Am just wondering how this is useful for the boot CPU.
> arch/arm64/kernel/smp.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 72c2823..f6ce2ae 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -254,6 +254,8 @@ void __init smp_init_cpus(void)
> }
> }
>
> + enable_method = of_get_property(dn, "enable-method", NULL);
> +
> /*
> * The numbering scheme requires that the boot CPU
> * must be assigned logical id 0. Record it so that
> @@ -269,11 +271,12 @@ void __init smp_init_cpus(void)
>
> bootcpu_valid = true;
>
> + if (enable_method)
> + smp_ops[0] = smp_get_ops(enable_method);
> +
> /*
> - * cpu_logical_map has already been
> - * initialized and the boot cpu doesn't need
> - * the enable-method so continue without
> - * incrementing cpu.
> + * cpu_logical_map has already been initialized so
> + * continue without incrementing cpu.
> */
> continue;
> }
> @@ -281,10 +284,6 @@ void __init smp_init_cpus(void)
> if (cpu >= NR_CPUS)
> goto next;
>
> - /*
> - * We currently support only the "spin-table" enable-method.
> - */
> - enable_method = of_get_property(dn, "enable-method", NULL);
> if (!enable_method) {
> pr_err("%s: missing enable-method property\n",
> dn->full_name);
>
next prev parent reply other threads:[~2013-08-14 18:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 16:20 [PATCHv3 0/5] arm64: initial CPU hotplug support Mark Rutland
2013-08-14 16:20 ` [PATCHv3 1/5] arm64: reorganise smp_enable_ops Mark Rutland
2013-08-14 17:46 ` Nicolas Pitre
2013-08-14 18:01 ` Santosh Shilimkar
2013-08-14 16:20 ` [PATCHv3 2/5] arm64: factor out spin-table boot method Mark Rutland
2013-08-14 17:51 ` Nicolas Pitre
2013-08-30 13:44 ` Catalin Marinas
2013-08-14 18:12 ` Santosh Shilimkar
2013-08-14 18:21 ` Nicolas Pitre
2013-08-14 19:17 ` Santosh Shilimkar
2013-08-14 19:21 ` Olof Johansson
2013-08-14 20:20 ` Nicolas Pitre
2013-08-14 16:20 ` [PATCHv3 3/5] arm64: read enable-method for CPU0 Mark Rutland
2013-08-14 17:51 ` Nicolas Pitre
2013-08-14 18:15 ` Santosh Shilimkar [this message]
2013-08-14 18:22 ` Nicolas Pitre
2013-08-14 19:02 ` Santosh Shilimkar
2013-08-14 16:20 ` [PATCHv3 4/5] arm64: add CPU_HOTPLUG infrastructure Mark Rutland
2013-08-14 17:53 ` Nicolas Pitre
2013-08-14 19:24 ` Santosh Shilimkar
2013-08-14 16:20 ` [PATCHv3 5/5] arm64: add PSCI CPU_OFF-based hotplug support Mark Rutland
2013-08-14 17:54 ` Nicolas Pitre
2013-08-14 18:05 ` [PATCHv3 0/5] arm64: initial CPU " Nicolas Pitre
2013-08-30 16:39 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520BC95B.6080307@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox