From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] drivers: CCI: add ARM CCI PMU support
Date: Wed, 14 Aug 2013 15:06:26 -0600 [thread overview]
Message-ID: <520BF152.1020704@wwwdotorg.org> (raw)
In-Reply-To: <1374571176-11584-1-git-send-email-punit.agrawal@arm.com>
On 07/23/2013 03:19 AM, Punit Agrawal wrote:
> The CCI PMU can profile bus transactions at the master and slave
> interfaces of the CCI. The PMU can be used to observe an aggregated view
> of the bus traffic between the various components connected to the CCI.
>
> Extend the existing CCI driver to support the PMU by registering a perf
> backend for it.
>
> Document the device tree binding to describe the CCI PMU.
> diff --git a/Documentation/devicetree/bindings/arm/cci.txt b/Documentation/devicetree/bindings/arm/cci.txt
> + - CCI PMU node
> +
> + Node name must be "pmu".
I don't think the binding should require the node to have a particular
name; node names shouldn't be interpret/used/relied-upon by drivers.
> + Parent node must be CCI interconnect node.
> +
> + A CCI pmu node must contain the following properties:
> +
> + - compatible
> + Usage: required
> + Value type: <string>
> + Definition: must be set to one of
> + "arm,cci-400-pmu"
> + "arm,cci-400-pmu,rev0"
> + "arm,cci-400-pmu,rev1"
What is the first entry in this list for; why wouldn't you always use
one of the two versioned compatible values?
The use of , before revN is a little unusual; I would have expected
arm,cci-400-pmu-rev0, but this isn't a big deal.
> + - interrupts:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: comma-separated list of unique PMU
> + interrupts
Is there more than one interrupt? The text seems to imply that. If so,
what are they, and which order must they appear?
next prev parent reply other threads:[~2013-08-14 21:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 3:00 [PATCH] drivers: CCI: add ARM CCI PMU support Punit Agrawal
2013-08-05 11:37 ` Punit Agrawal
2013-08-07 1:45 ` Will Deacon
2013-08-12 13:59 ` Will Deacon
2013-08-12 16:08 ` Will Deacon
2013-08-12 16:58 ` Punit Agrawal
2013-08-14 21:03 ` Kumar Gala
2013-08-14 22:38 ` Rob Herring
2013-08-15 10:01 ` Punit Agrawal
2013-08-15 9:10 ` Punit Agrawal
2013-08-15 16:25 ` Kumar Gala
2013-08-16 10:31 ` Punit Agrawal
2013-08-16 10:53 ` Kumar Gala
2013-08-15 19:00 ` Kumar Gala
2013-08-16 10:56 ` Punit Agrawal
2013-08-16 11:31 ` Kumar Gala
2013-08-16 12:41 ` Punit Agrawal
2013-08-14 21:06 ` Stephen Warren [this message]
2013-08-14 21:09 ` Kumar Gala
2013-08-14 21:13 ` Stephen Warren
2013-08-14 21:16 ` Kumar Gala
2013-08-15 10:09 ` Punit Agrawal
2013-08-16 17:19 ` [PATCH v2] " Punit Agrawal
2013-08-16 18:31 ` Stephen Warren
2013-08-19 11:14 ` Punit Agrawal
2013-08-19 16:15 ` Stephen Warren
2013-08-16 18:47 ` Kumar Gala
2013-08-19 11:21 ` Punit Agrawal
2013-08-20 15:07 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520BF152.1020704@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox