From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/5] ARM: tegra: add support for Trusted Foundations
Date: Wed, 14 Aug 2013 15:38:05 -0600 [thread overview]
Message-ID: <520BF8BD.7050706@wwwdotorg.org> (raw)
In-Reply-To: <1376360992-1508-3-git-send-email-acourbot@nvidia.com>
On 08/12/2013 08:29 PM, Alexandre Courbot wrote:
> Register the firmware operations for Trusted Foundations if the device
> tree indicates it is active on the device.
> diff --git a/arch/arm/mach-tegra/firmware.c b/arch/arm/mach-tegra/firmware.c
> +void __init tegra_init_firmware(void)
> +{
> + struct device_node *node;
> +
> + if (!of_have_populated_dt())
> + return;
That's never false on Tegra, at least upstream.
> + node = of_find_compatible_node(NULL, NULL, "tl,trusted-foundations");
> + if (node) {
> + const char *tf_version;
> + int err;
> +
> + err = of_property_read_string(node, "version", &tf_version);
> + if (err != 0) {
> + pr_crit("Cannot read Trusted Foundation version: %d\n",
> + err);
> + BUG();
> + } else {
> + register_trusted_foundations(tf_version);
> + }
> + }
> +}
I think most/all of that function will be common across all SoCs that
support the TF monitor. I think you want to move the code into
register_trusted_foundations() (or a function that calls that) in patch 1?
next prev parent reply other threads:[~2013-08-14 21:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 2:29 [PATCH v3 0/5] ARM: tegra: support for Trusted Foundations Alexandre Courbot
2013-08-13 2:29 ` [PATCH v3 1/5] ARM: add basic Trusted Foundations support Alexandre Courbot
2013-08-14 21:35 ` Stephen Warren
2013-08-18 8:37 ` Alexandre Courbot
2013-08-19 15:56 ` Stephen Warren
2013-08-15 11:52 ` Dave Martin
2013-08-15 22:02 ` Stephen Warren
2013-08-16 13:23 ` Dave Martin
2013-08-18 8:38 ` Alexandre Courbot
2013-08-18 8:37 ` Alexandre Courbot
2013-08-13 2:29 ` [PATCH v3 2/5] ARM: tegra: add support for Trusted Foundations Alexandre Courbot
2013-08-14 21:38 ` Stephen Warren [this message]
2013-08-18 8:37 ` Alexandre Courbot
2013-08-13 2:29 ` [PATCH v3 3/5] ARM: tegra: split setting of CPU reset handler Alexandre Courbot
2013-08-13 2:29 ` [PATCH v3 4/5] ARM: tegra: set CPU reset handler with firmware op Alexandre Courbot
2013-08-14 21:40 ` Stephen Warren
2013-08-18 8:37 ` Alexandre Courbot
2013-08-13 2:29 ` [PATCH v3 5/5] ARM: tegra: support Trusted Foundations by default Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520BF8BD.7050706@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox