From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC 3/3] PCI: tegra: Support driver unbinding
Date: Wed, 14 Aug 2013 15:43:40 -0600 [thread overview]
Message-ID: <520BFA0C.5070001@wwwdotorg.org> (raw)
In-Reply-To: <1376392346-14127-4-git-send-email-treding@nvidia.com>
On 08/13/2013 05:12 AM, Thierry Reding wrote:
> Implement the platform driver's .remove() callback to free all resources
> allocated during driver setup and call pci_common_exit() to cleanup ARM
> specific datastructures. Unmap the fixed PCI I/O mapping by calling the
> new pci_iounmap_io() function in the new .teardown() callback.
>
> Finally, no longer set the .suppress_bind_attrs field to true to allow
> the driver to unbind from a device.
> +static int tegra_pcie_remove(struct platform_device *pdev)
> +{
> + struct tegra_pcie *pcie = platform_get_drvdata(pdev);
> + struct tegra_pcie_bus *bus, *tmp;
> + int err;
> +
> + pci_common_exit(&pcie->sys);
> +
> + list_for_each_entry_safe(bus, tmp, &pcie->busses, list) {
> + vunmap(bus->area->addr);
> + kfree(bus);
> + }
> +
> + if (IS_ENABLED(CONFIG_PCI_MSI)) {
> + err = tegra_pcie_disable_msi(pcie);
> + if (err < 0)
> + return err;
> + }
Wouldn't it make sense to do that as early as possible in the function,
to make sure that no MSI accidentally fires after some of the cleanup
has already happened?
> +
> + err = tegra_pcie_put_resources(pcie);
> + if (err < 0)
> + return err;
> +
> + return 0;
> +}
next prev parent reply other threads:[~2013-08-14 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 11:12 [RFC 0/3] ARM: Allow PCI host drivers to be unloaded Thierry Reding
[not found] ` <1376392346-14127-4-git-send-email-treding@nvidia.com>
2013-08-14 21:43 ` Stephen Warren [this message]
2013-08-15 10:34 ` [RFC 3/3] PCI: tegra: Support driver unbinding Thierry Reding
2013-08-15 15:21 ` Stephen Warren
2013-08-19 20:16 ` Thierry Reding
2013-08-19 20:55 ` Stephen Warren
2013-08-19 21:52 ` Thierry Reding
2013-08-19 21:59 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520BFA0C.5070001@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox