public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: linux@roeck-us•net (Guenter Roeck)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 10/29] drivers/watchdog/nuc900_wdt.c: simplify use of devm_ioremap_resource
Date: Wed, 14 Aug 2013 20:17:03 -0700	[thread overview]
Message-ID: <520C482F.5090806@roeck-us.net> (raw)
In-Reply-To: <1376471493-22215-11-git-send-email-Julia.Lawall@lip6.fr>

On 08/14/2013 02:11 AM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6•fr>
>
> Remove unneeded error handling on the result of a call to
> platform_get_resource when the value is passed to devm_ioremap_resource.
>
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression pdev,res,n,e,e1;
> expression ret != 0;
> identifier l;
> @@
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, n);
>    ... when != res
> - if (res == NULL) { ... \(goto l;\|return ret;\) }
>    ... when != res
> + res = platform_get_resource(pdev, IORESOURCE_MEM, n);
>    e = devm_ioremap_resource(e1, res);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6•fr>
>
Reviewed-by: Guenter Roeck <linux@roeck-us•net>

  reply	other threads:[~2013-08-15  3:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14  9:11 [PATCH 0/29] simplify use of devm_ioremap_resource Julia Lawall
2013-08-14  9:11 ` [PATCH 1/29] pinctrl: nomadik: " Julia Lawall
2013-08-15 20:02   ` Linus Walleij
2013-08-14  9:11 ` [PATCH 10/29] drivers/watchdog/nuc900_wdt.c: " Julia Lawall
2013-08-15  3:17   ` Guenter Roeck [this message]
2013-08-15  3:29     ` Wan ZongShun
2013-08-14  9:11 ` [PATCH 12/29] sound/soc/samsung/ac97.c: " Julia Lawall
2013-08-14 18:14   ` Mark Brown
2013-08-14  9:11 ` [PATCH 20/29] watchdog: s3c2410_wdt: " Julia Lawall
2013-08-15  3:19   ` Guenter Roeck
2013-08-14  9:11 ` [PATCH 25/29] drivers/spi/spi-sirf.c: " Julia Lawall
2013-08-14  9:16   ` Barry Song
2013-08-14 18:09   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520C482F.5090806@roeck-us.net \
    --to=linux@roeck-us$(echo .)net \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox