From: rogerq@ti•com (Roger Quadros)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 6/8] usb: phy: omap: get rid of omap_get_control_dev()
Date: Fri, 16 Aug 2013 12:00:27 +0300 [thread overview]
Message-ID: <520DEA2B.5030608@ti.com> (raw)
In-Reply-To: <20130815165152.GB10982@linutronix.de>
On 08/15/2013 07:51 PM, Sebastian Andrzej Siewior wrote:
> * Roger Quadros | 2013-08-15 16:15:10 [+0300]:
>
>> diff --git a/drivers/usb/phy/phy-omap-control.c b/drivers/usb/phy/phy-omap-control.c
>> index 078c46f..d144c14 100644
>> --- a/drivers/usb/phy/phy-omap-control.c
>> +++ b/drivers/usb/phy/phy-omap-control.c
>> @@ -187,11 +167,19 @@ void omap_control_usb_set_mode(struct device *dev,
>> {
>> struct omap_control_usb *ctrl_usb;
>>
>> - if (IS_ERR(dev) || control_usb->type != OMAP_CTRL_TYPE_OMAP)
>> + if (IS_ERR(dev) || !dev)
>> return;
>>
>> ctrl_usb = dev_get_drvdata(dev);
>>
>> + if (!ctrl_usb) {
>> + dev_err(dev, "Invalid control usb device\n");
>> + return;
>> + }
>> +
>> + if (ctrl_usb->type != OMAP_CTRL_TYPE_OMAP)
>> + return;
>> +
>
> I don't like that part where you can call this function even before the
> driver probed the device. This shouldn't happen since you have hard module
> dependency and the proper compatible string in your device. But this
> kind of thing won't happen in the am335x reset driver.
I don't like that part either, but omap_control_usb_set_mode is being called
from outside this driver (e.g. musb) and we are not making any changes to that behaviour
in this patch.
I think the issue you mentioned is being fixed by Kishon's extcon migration series.
cheers,
-roger
next prev parent reply other threads:[~2013-08-16 9:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 13:15 [PATCH v2 0/8] phy: omap-usb: Support multiple instances and new types Roger Quadros
2013-08-15 13:15 ` [PATCH v2 1/8] usb: phy: omap-control: Get rid of platform data Roger Quadros
2013-08-15 16:22 ` Sebastian Andrzej Siewior
2013-08-16 8:57 ` Roger Quadros
2013-08-15 13:15 ` [PATCH v2 2/8] usb: phy: omap: Add new device types and remove omap_control_usb3_phy_power() Roger Quadros
2013-08-15 13:58 ` Benoit Cousson
2013-08-16 9:09 ` Roger Quadros
2013-08-15 13:15 ` [PATCH v2 3/8] usb: phy: omap-usb2: Don't use omap_get_control_dev() Roger Quadros
2013-08-15 13:15 ` [PATCH v2 4/8] usb: phy: omap-usb3: " Roger Quadros
2013-08-15 13:15 ` [PATCH v2 5/8] usb: musb: omap2430: " Roger Quadros
2013-08-15 13:15 ` [PATCH v2 6/8] usb: phy: omap: get rid of omap_get_control_dev() Roger Quadros
2013-08-15 16:51 ` Sebastian Andrzej Siewior
2013-08-16 9:00 ` Roger Quadros [this message]
2013-08-16 9:07 ` Sebastian Andrzej Siewior
2013-08-15 13:15 ` [PATCH v2 7/8] ARM: dts: omap4: update omap-control-usb nodes Roger Quadros
2013-08-15 13:15 ` [PATCH v2 8/8] ARM: dts: omap5: update omap-control-usb node Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520DEA2B.5030608@ti.com \
--to=rogerq@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox