From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] extcon: palmas: Modified the compatible type to *ti, palmas-usb-vid*
Date: Mon, 19 Aug 2013 14:59:07 +0530 [thread overview]
Message-ID: <5211E563.6080200@ti.com> (raw)
In-Reply-To: <5211E45B.1010109@samsung.com>
On Monday 19 August 2013 02:54 PM, Chanwoo Choi wrote:
> On 08/19/2013 05:47 PM, Kishon Vijay Abraham I wrote:
>> On Monday 19 August 2013 10:35 AM, Kishon Vijay Abraham I wrote:
>>> Hi,
>>>
>>> On Saturday 17 August 2013 03:51 AM, Stephen Warren wrote:
>>>> On 08/16/2013 04:20 AM, Kishon Vijay Abraham I wrote:
>>>>> The Palmas device contains only a USB VID detector, so modified the
>>>>> compatible type to *ti,palmas-usb-vid*.
>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
>>>>
>>>>> PALMAS USB COMPARATOR
>>>>> Required Properties:
>>>>> - - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
>>>>> + - compatible : Should be "ti,palmas-usb-vid".
>>>>
>>>> Has the old value been published in a release kernel? If so, it makes
>>>
>>> No. This was merged only in 3.11-rc1. So I think we should take this version?
>>> Chanwoo can you take this patch?
>>
>> Ah.. the old values will be part of 3.11 kernel. So should we retain the old
>> values?
>
> What is the meaning of old value? previous value related to extcon-twl.txt?
We were discussing on whether to have "ti,palmas-usb" or "ti,twl6035-usb" in
compatible value in addition to "ti,palmas-usb-vid". Stephen wanted the old
values ("ti,palmas-usb" or "ti,twl6035-usb") if it has been published in a
release kernel.
>
> The extcon-twl.txt was included in 3.11 kernel
Right. Since it's part of 3.11 kernel, I think we should retain the old
compatible values.
Thanks
Kishon
next prev parent reply other threads:[~2013-08-19 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 10:20 [PATCH v2] extcon: palmas: Modified the compatible type to *ti, palmas-usb-vid* Kishon Vijay Abraham I
2013-08-16 22:21 ` Stephen Warren
2013-08-19 5:05 ` Kishon Vijay Abraham I
2013-08-19 8:33 ` [PATCH v2] extcon: palmas: Modified the compatible type to *ti,palmas-usb-vid* Chanwoo Choi
2013-08-19 8:47 ` [PATCH v2] extcon: palmas: Modified the compatible type to *ti, palmas-usb-vid* Kishon Vijay Abraham I
2013-08-19 9:24 ` [PATCH v2] extcon: palmas: Modified the compatible type to *ti,palmas-usb-vid* Chanwoo Choi
2013-08-19 9:29 ` Kishon Vijay Abraham I [this message]
2013-08-19 10:21 ` [PATCH v2] extcon: palmas: Modified the compatible type to *ti, palmas-usb-vid* Benoit Cousson
2013-08-19 10:26 ` Kishon Vijay Abraham I
2013-08-19 16:11 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5211E563.6080200@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox