From: t-kristo@ti•com (Tero Kristo)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv5 22/31] CLK: TI: add interface clock support for OMAP3
Date: Mon, 19 Aug 2013 16:54:28 +0300 [thread overview]
Message-ID: <52122394.9040904@ti.com> (raw)
In-Reply-To: <20130813113010.GN27165@e106331-lin.cambridge.arm.com>
On 08/13/2013 02:30 PM, Mark Rutland wrote:
> On Fri, Aug 02, 2013 at 05:25:41PM +0100, Tero Kristo wrote:
>> OMAP3 has interface clocks in addition to functional clocks, which
>> require special handling for the autoidle and idle status register
>> offsets mainly.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti•com>
>> ---
>> .../devicetree/bindings/clock/ti/interface.txt | 45 +++++++++
>> arch/arm/mach-omap2/clock.h | 6 --
>> drivers/clk/ti/Makefile | 2 +-
>> drivers/clk/ti/interface.c | 105 ++++++++++++++++++++
>> include/linux/clk/ti.h | 7 ++
>> 5 files changed, 158 insertions(+), 7 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/clock/ti/interface.txt
>> create mode 100644 drivers/clk/ti/interface.c
>>
>> diff --git a/Documentation/devicetree/bindings/clock/ti/interface.txt b/Documentation/devicetree/bindings/clock/ti/interface.txt
>> new file mode 100644
>> index 0000000..8b09ae7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/ti/interface.txt
>> @@ -0,0 +1,45 @@
>> +Binding for Texas Instruments interface clock.
>> +
>> +This binding uses the common clock binding[1]. This clock is
>> +quite much similar to the basic gate-clock [2], however,
>> +it supports a number of additional features, including
>> +companion clock finding (match corresponding functional gate
>> +clock) and hardware autoidle enable / disable.
>> +
>> +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
>> +[2] Documentation/devicetree/bindings/clock/gate-clock.txt
>> +
>> +Required properties:
>> +- compatible : shall be "ti,interface-clock"
>
> It might make sense to be more specific: "ti,omap3-interface-clock".
Ok.
>
>> +- #clock-cells : from common clock binding; shall be set to 0
>> +- clocks : link to phandle of parent clock
>> +- reg : base address for the control register
>> +
>> +Optional properties:
>> +- ti,enable-bit : bit shift for the bit enabling/disabling the clock
>> + (default 0)
>> +- ti,iclk-no-wait : flag for selecting non-waiting hw-ops
>> +- ti,iclk-hsotgusb : flag for selecting hsotgusb hw-ops
>> +- ti,iclk-dss : flag for selecting DSS interface clock hw-ops
>> +- ti,iclk-ssi : flag for selecting SSI interface clock hw-ops
>> +- ti,am35xx-clk : flag for selecting AM35xx interface clock hw-ops
>
> I think these should be selected based on the compatible string. They're
> mutually exclusive, and incompatible.
Ok, I'll change this for next rev so that each has its own compatible
string.
Thanks for your comments Mark.
-Tero
next prev parent reply other threads:[~2013-08-19 13:54 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 16:25 [PATCHv5 00/31] CLK: OMAP conversion to DT Tero Kristo
2013-08-02 16:25 ` [PATCHv5 01/31] CLK: clkdev: add support for looking up clocks from DT Tero Kristo
2013-08-03 14:02 ` Tomasz Figa
2013-08-03 18:35 ` Russell King - ARM Linux
2013-08-03 18:39 ` Tomasz Figa
2013-08-03 18:48 ` Russell King - ARM Linux
2013-08-03 19:04 ` Tomasz Figa
2013-08-19 9:12 ` Tero Kristo
2013-08-03 18:31 ` Russell King - ARM Linux
2013-08-26 14:36 ` Tero Kristo
2013-08-26 17:03 ` Russell King - ARM Linux
2013-08-26 18:12 ` Tero Kristo
2013-08-27 6:55 ` Tony Lindgren
2013-08-02 16:25 ` [PATCHv5 02/31] CLK: TI: Add DPLL clock support Tero Kristo
2013-08-13 10:50 ` Mark Rutland
2013-08-19 13:34 ` Tero Kristo
2013-08-19 14:18 ` Mark Rutland
2013-08-19 15:09 ` Tero Kristo
2013-08-19 16:24 ` Mark Rutland
2013-08-19 17:06 ` Tero Kristo
2013-08-19 22:00 ` Mike Turquette
2013-08-21 16:16 ` Tero Kristo
2013-08-22 8:04 ` Mike Turquette
2013-08-02 16:25 ` [PATCHv5 03/31] CLK: TI: add DT alias clock registration mechanism Tero Kristo
2013-08-02 16:25 ` [PATCHv5 04/31] CLK: TI: add autoidle support Tero Kristo
2013-08-02 16:25 ` [PATCHv5 05/31] CLK: TI: add support for OMAP gate clock Tero Kristo
2013-08-13 11:04 ` Mark Rutland
2013-08-19 13:42 ` Tero Kristo
2013-08-19 14:29 ` Mark Rutland
2013-08-19 14:43 ` Tero Kristo
2013-08-19 15:58 ` Mark Rutland
2013-08-19 16:19 ` Tero Kristo
2013-08-02 16:25 ` [PATCHv5 06/31] ARM: dts: omap4 clock data Tero Kristo
2013-08-03 14:16 ` Tomasz Figa
2013-08-19 13:43 ` Tero Kristo
2013-08-02 16:25 ` [PATCHv5 07/31] CLK: TI: add omap4 clock init file Tero Kristo
2013-08-05 7:27 ` Tony Lindgren
2013-08-19 13:46 ` Tero Kristo
2013-08-02 16:25 ` [PATCHv5 08/31] ARM: OMAP4: remove old clock data and link in new clock init code Tero Kristo
2013-08-02 16:25 ` [PATCHv5 09/31] ARM: dts: omap5 clock data Tero Kristo
2013-08-02 16:25 ` [PATCHv5 10/31] CLK: TI: add omap5 clock init file Tero Kristo
2013-08-02 16:25 ` [PATCHv5 11/31] CLK: TI: omap5: Initialize USB_DPLL at boot Tero Kristo
2013-08-02 16:25 ` [PATCHv5 12/31] ARM: dts: dra7 clock data Tero Kristo
2013-08-02 16:25 ` [PATCHv5 13/31] ARM: dts: clk: Add apll related clocks Tero Kristo
2013-08-02 16:25 ` [PATCHv5 14/31] ARM: dts: DRA7: Change apll_pcie_m2_ck to fixed factor clock Tero Kristo
2013-08-02 16:25 ` [PATCHv5 15/31] ARM: dts: DRA7: Add PCIe related clock nodes Tero Kristo
2013-08-02 16:25 ` [PATCHv5 16/31] CLK: TI: DRA7: Add APLL support Tero Kristo
2013-08-13 11:14 ` Mark Rutland
2013-08-19 13:52 ` Tero Kristo
2013-08-20 4:09 ` Keerthy
2013-08-02 16:25 ` [PATCHv5 17/31] CLK: TI: add dra7 clock init file Tero Kristo
2013-08-02 16:25 ` [PATCHv5 18/31] CLK: DT: add support for set-rate-parent flag Tero Kristo
2013-08-13 11:25 ` Mark Rutland
2013-08-02 16:25 ` [PATCHv5 19/31] ARM: dts: am33xx clock data Tero Kristo
2013-08-02 16:25 ` [PATCHv5 20/31] CLK: TI: add am33xx clock init file Tero Kristo
2013-08-02 16:25 ` [PATCHv5 21/31] ARM: AM33xx: remove old clock data and link in new clock init code Tero Kristo
2013-08-02 16:25 ` [PATCHv5 22/31] CLK: TI: add interface clock support for OMAP3 Tero Kristo
2013-08-13 11:30 ` Mark Rutland
2013-08-19 13:54 ` Tero Kristo [this message]
2013-08-02 16:25 ` [PATCHv5 23/31] ARM: OMAP: hwmod: fix an incorrect clk type cast with _get_clkdm Tero Kristo
2013-08-02 16:25 ` [PATCHv5 24/31] CLK: TI: gate: add support for OMAP36xx dpllx_mx_ck:s Tero Kristo
2013-08-02 16:25 ` [PATCHv5 25/31] ARM: OMAP3: hwmod: initialize clkdm from clkdm_name Tero Kristo
2013-08-02 16:25 ` [PATCHv5 26/31] ARM: dts: omap3 clock data Tero Kristo
2013-08-02 16:25 ` [PATCHv5 27/31] CLK: TI: add omap3 clock init file Tero Kristo
2013-08-02 16:25 ` [PATCHv5 28/31] ARM: dts: AM35xx clock data Tero Kristo
2013-08-02 16:25 ` [PATCHv5 29/31] ARM: dts: AM35xx: use DT " Tero Kristo
2013-08-02 16:25 ` [PATCHv5 30/31] ARM: OMAP3: use DT clock init if DT data is available Tero Kristo
2013-08-02 16:25 ` [PATCHv5 31/31] ARM: dts: am43xx clock data Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52122394.9040904@ti.com \
--to=t-kristo@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox