From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 3/4] drivers: of: add initialization code for dma reserved memory
Date: Mon, 19 Aug 2013 15:49:20 -0600 [thread overview]
Message-ID: <521292E0.105@wwwdotorg.org> (raw)
In-Reply-To: <1376924669-28873-4-git-send-email-m.szyprowski@samsung.com>
On 08/19/2013 09:04 AM, Marek Szyprowski wrote:
> This patch adds device tree support for contiguous and reserved memory
> regions defined in device tree.
> diff --git a/Documentation/devicetree/bindings/memory.txt b/Documentation/devicetree/bindings/memory.txt
> +*** Reserved memory regions ***
> +
> +In /memory/reserved-memory node one can create additional nodes
s/additional/child/ or s/additional/sub/ would make it clearer where the
"additional" nodes should be placed.
> +compatible: "linux,contiguous-memory-region" - enables binding of this
> + region to Contiguous Memory Allocator (special region for
> + contiguous memory allocations, shared with movable system
> + memory, Linux kernel-specific), alternatively if
> + "reserved-memory-region" - compatibility is defined, given
> + region is assigned for exclusive usage for by the respective
> + devices
"alternatively" makes it sound like the two compatible values are
mutually-exclusive. Perhaps make this a list, like:
----------
compatible: One or more of:
- "linux,contiguous-memory-region" - enables binding of this
region to Contiguous Memory Allocator (special region for
contiguous memory allocations, shared with movable system
memory, Linux kernel-specific).
- "reserved-memory-region" - compatibility is defined, given
region is assigned for exclusive usage for by the respective
devices.
----------
"linux,contiguous-memory-region" is already long enough, but I'd
slightly bikeshed towards "linux,contiguous-memory-allocator-region", or
perhaps "linux,cma-region" since it's not really describing whether the
memory is contiguous (at the level of /memory, each chunk of memory is
contiguous...)
> +*** Device node's properties ***
> +
> +Once regions in the /memory/reserved-memory node have been defined, they
> +can be assigned to device nodes to enable respective device drivers to
> +access them. The following properties are defined:
> +
> +memory-region = <&phandle_to_defined_region>;
I think the naming of that property should more obviously match this
binding and/or compatible value; perhaps cma-region or
contiguous-memory-region?
next prev parent reply other threads:[~2013-08-19 21:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 15:04 [PATCH v6 0/4] Device Tree support for CMA (Contiguous Memory Allocator) Marek Szyprowski
2013-08-19 15:04 ` [PATCH v6 1/4] drivers: dma-contiguous: clean source code and prepare for device tree Marek Szyprowski
2013-08-19 15:04 ` [PATCH v6 2/4] drivers: of: add function to scan fdt nodes given by path Marek Szyprowski
2013-08-26 12:09 ` Rob Herring
2013-08-19 15:04 ` [PATCH v6 3/4] drivers: of: add initialization code for dma reserved memory Marek Szyprowski
2013-08-19 21:49 ` Stephen Warren [this message]
2013-08-19 22:02 ` Tomasz Figa
2013-08-19 22:17 ` Stephen Warren
2013-08-19 22:24 ` Tomasz Figa
2013-08-19 22:27 ` Stephen Warren
2013-08-19 22:40 ` Tomasz Figa
2013-08-19 22:54 ` Stephen Warren
2013-08-20 10:57 ` Marek Szyprowski
2013-08-20 16:35 ` Stephen Warren
2013-08-21 14:38 ` Marek Szyprowski
2013-08-22 20:08 ` Stephen Warren
2013-08-21 15:39 ` Tomasz Figa
2013-08-29 21:20 ` Grant Likely
2013-08-29 21:12 ` Grant Likely
2013-08-21 15:56 ` Matt Sealey
[not found] ` <1377247141-11284-1-git-send-email-m.szyprowski@samsung.com>
2013-08-23 19:27 ` [PATCH v6 3/4 UPDATED] " Stephen Warren
2013-08-26 12:20 ` [PATCH v6 3/4] " Rob Herring
2013-08-19 15:04 ` [PATCH v6 4/4] ARM: init: add support for reserved memory defined by device tree Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521292E0.105@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox