From: bcousson@baylibre•com (Benoit Cousson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 00/13] ARM: OMAP2+: AM43x PRCM support
Date: Tue, 20 Aug 2013 11:18:58 +0200 [thread overview]
Message-ID: <52133482.7080405@baylibre.com> (raw)
In-Reply-To: <5211BD07.9090309@ti.com>
+ Rajendra and Tero,
Hi Afzal,
On 19/08/2013 08:36, Afzal Mohammed wrote:
> Hi Tony,
>
> On Tuesday 13 August 2013 01:31 PM, Tony Lindgren wrote:
>
>> Hi Paul & Benoit,
>>
>> Does this series look OK to you guys to queue or ack?
>
>
> Can you please consider queuing this series for the coming merge window
> as we are getting closer to the merge window.
>
> If Paul or Benoit has any comments on this, we can have patches to fix
> it up on top of this as required or these patches be reverted in the
> worst case.
That series is pretty big and I will not have the time to review it
properly. Moreover, without any public documentation, it will be really
hard to do a correct review anyway.
That series must be reviewed and acked by people inside TI who does have
the knowledge and the skill to do that.
I strongly recommend you to ask Rajendra and Tero to review it and ack
it ASAP.
Otherwise, I guess that most of these patches should be non-intrusive
for other OMAPs beside that one (ARM: OMAP2+: CM: reintroduce SW_SLEEP
for OMAP4). And for the moment, that's maybe the most important point.
Have you checked that it will not generate any regression for OMAP4 in
term of PM features: suspend, cpuidle at least?
Regards,
Benoit
>
> Regards
> Afzal
>
>>
>> * Afzal Mohammed <afzal@ti•com> [130802 06:42]:
>>> Hi,
>>>
>>> AM43x PRCM support (excluding clock tree) is being added with this
>>> series. AM43x reuses most of the IP's from AM335x, as that is the
>>> case, much of the AM335x hwmod data is reused.
>>>
>>> I am aware that this series adds around +1K lines to platform. We in
>>> TI, here are making efforts to clean platform code gradually and keep
>>> to minumum the code being added to support new SoC's. Please note that
>>> this SoC support series has positive diffstat of just above 1K only.
>>> This compared to last SoC that was supported in OMAP family during
>>> last merge window is way less (this is only around 1/8th postive
>>> diffstat of it). Clock data is not added in this series, instead
>>> directly clock tree in DT with driver would be used, this is a work in
>>> progress. And as seen from recent OMAP clock tree DT conversion
>>> series, there are serious efforts ongoing to that end. Also we will
>>> start working on moving hwmod away from platform folders. In addition,
>>> recently there was a PRCM cleanup by Rajendra Nayak that removed near
>>> to 11K lines.
>>>
>>> Considering the above facts, I request the maintainers to consider
>>> this series for the next merge window.
>>>
>>> Currently there is no public TRM available for AM43x.
>>>
>>> Hwmod database of AM335x is reused by moving common elements to a new
>>> array (most of AM335x IP's are present in AM43x) and keeping separate
>>> arrays for elements that are specific only to either one of AM335x or
>>> AM43x. And in the cases where relevant IP is present in both that has
>>> difference in details like CLKCTRL register offsets, it is being
>>> updated at runtime based on the SoC detected.
>>>
>>> Powerdomain & Clockdomain data has been added separately as it was not
>>> giving much advantage reusing AM335x ones (runtime updates required
>>> was getting too ugly). But as AM43x PRCM functionality is similar to
>>> OMAP4, power domain, clock domain & hwmod operations are reused from
>>> OMAP4.
>>>
>>> A single header file has been added to provide all AM43x PRCM defines.
>>>
>>> Here sequencewise, initially AM335x hwmod is modified to have it's
>>> fields get updated at runtime (wherever element is shared and has
>>> some difference with AM43x). Then power domain, clock domain for AM43x
>>> is added and finally AM335x hwmod database is updated with AM43x
>>> specifics.
>>>
>>> This series is being developed with additional clock tree changes that
>>> are being DT'fied.
>>>
>>> Additional DTS changes (posted separate from this series) are also
>>> required for hwmod to get register target address space as most of
>>> AM335x hwmod address space details has been recently cleaned up and
>>> moved to DTS.
>>>
>>> Regards
>>> Afzal
>>>
>>> Afzal Mohammed (8):
>>> ARM: OMAP2+: hwmod: AM335x: prepare for AM43x reuse
>>> ARM: OMAP2+: hwmod: AMx3: runtime AM335x handling
>>> ARM: OMAP2+: hwmod: AMx3: remove common static fields
>>> ARM: OMAP2+: PRCM: AM43x definitions
>>> ARM: OMAP2+: hwmod: AMx3: runtime AM43x handling
>>> ARM: OMAP2+: hwmod: AM43x operations
>>> ARM: OMAP2+: AM43x: PRCM kbuild
>>> ARM: OMAP2+: hwmod: AM43x: new w.r.t AM335x
>>>
>>> Ambresh K (3):
>>> ARM: OMAP2+: PM: AM43x powerdomain data
>>> ARM: OMAP2+: CM: AM43x clockdomain data
>>> ARM: OMAP2+: AM43x PRCM init
>>>
>>> Ankur Kishore (1):
>>> ARM: OMAP2+: CM: cm_inst offset s16->u16
>>>
>>> Vaibhav Bedia (1):
>>> ARM: OMAP2+: CM: reintroduce SW_SLEEP for OMAP4
>>>
>>> arch/arm/mach-omap2/Makefile | 5 +-
>>> arch/arm/mach-omap2/clockdomain.h | 4 +-
>>> arch/arm/mach-omap2/clockdomains43xx_data.c | 199 ++++++++
>>> arch/arm/mach-omap2/cm33xx.c | 30 +-
>>> arch/arm/mach-omap2/cm33xx.h | 28 +-
>>> arch/arm/mach-omap2/cminst44xx.c | 58 ++-
>>> arch/arm/mach-omap2/cminst44xx.h | 25 +-
>>> arch/arm/mach-omap2/io.c | 6 +
>>> arch/arm/mach-omap2/omap_hwmod.c | 8 +
>>> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 691 +++++++++++++++++++++++----
>>> arch/arm/mach-omap2/powerdomain.h | 1 +
>>> arch/arm/mach-omap2/powerdomains43xx_data.c | 145 ++++++
>>> arch/arm/mach-omap2/prcm43xx.h | 141 ++++++
>>> 13 files changed, 1198 insertions(+), 143 deletions(-)
>>> create mode 100644 arch/arm/mach-omap2/clockdomains43xx_data.c
>>> create mode 100644 arch/arm/mach-omap2/powerdomains43xx_data.c
>>> create mode 100644 arch/arm/mach-omap2/prcm43xx.h
>>>
>>> --
>>> 1.7.9.5
>>>
>
next prev parent reply other threads:[~2013-08-20 9:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 13:35 [PATCH v2 00/13] ARM: OMAP2+: AM43x PRCM support Afzal Mohammed
2013-08-02 13:36 ` [PATCH v2 01/13] ARM: OMAP2+: CM: reintroduce SW_SLEEP for OMAP4 Afzal Mohammed
2013-08-21 7:13 ` Rajendra Nayak
2013-08-28 12:14 ` Afzal Mohammed
2013-08-30 18:04 ` Vaibhav Bedia
2013-08-02 13:36 ` [PATCH v2 02/13] ARM: OMAP2+: hwmod: AM335x: prepare for AM43x reuse Afzal Mohammed
2013-08-21 8:37 ` Rajendra Nayak
2013-08-02 13:36 ` [PATCH v2 03/13] ARM: OMAP2+: hwmod: AMx3: runtime AM335x handling Afzal Mohammed
2013-08-21 11:28 ` Rajendra Nayak
2013-08-02 13:37 ` [PATCH v2 04/13] ARM: OMAP2+: hwmod: AMx3: remove common static fields Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 05/13] ARM: OMAP2+: CM: cm_inst offset s16->u16 Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 06/13] ARM: OMAP2+: PRCM: AM43x definitions Afzal Mohammed
2013-08-21 3:20 ` Paul Walmsley
2013-08-28 12:03 ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 07/13] ARM: OMAP2+: PM: AM43x powerdomain data Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 08/13] ARM: OMAP2+: CM: AM43x clockdomain data Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 09/13] ARM: OMAP2+: hwmod: AMx3: runtime AM43x handling Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 10/13] ARM: OMAP2+: hwmod: AM43x operations Afzal Mohammed
2013-08-21 11:30 ` Rajendra Nayak
2013-08-28 12:29 ` Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 11/13] ARM: OMAP2+: AM43x: PRCM kbuild Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 12/13] ARM: OMAP2+: AM43x PRCM init Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 13/13] ARM: OMAP2+: hwmod: AM43x: new w.r.t AM335x Afzal Mohammed
2013-08-21 11:33 ` Rajendra Nayak
2013-08-13 8:01 ` [PATCH v2 00/13] ARM: OMAP2+: AM43x PRCM support Tony Lindgren
2013-08-19 6:36 ` Afzal Mohammed
2013-08-20 9:18 ` Benoit Cousson [this message]
2013-08-28 12:09 ` Afzal Mohammed
2013-08-21 2:53 ` Paul Walmsley
2013-08-28 12:03 ` Afzal Mohammed
2013-08-21 11:44 ` Rajendra Nayak
2013-08-29 14:00 ` Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52133482.7080405@baylibre.com \
--to=bcousson@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox