From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 1/3] i2c-mv64xxx: Add I2C Transaction Generator support
Date: Tue, 20 Aug 2013 17:56:02 +0200 [thread overview]
Message-ID: <52139192.5070507@free-electrons.com> (raw)
In-Reply-To: <20130815121340.GB17155@katana>
On 15/08/2013 14:13, Wolfram Sang wrote:
>
>> + if ((msg->flags & I2C_M_RD) == 0) { + for (i = 0; i < 4 && i < msg->len; i++) + data_reg_lo = data_reg_lo | + (msg->buf[i] << ((i & 0x3) * 8)); + + for (i = 4; i < 8 && i <
>> msg->len; i++) + data_reg_hi = data_reg_hi | + (msg->buf[i] << ((i & 0x3) * 8));
>
> Same comment as in the last version: What about be32_to_cpu and friends instead of the loops (here and later)?
>
We can't use be32_to_cpu and friends, because one of the stop condition of this
loop is the length of the msg.
For reading from msg->buf we could consider to mask the irrelevant part.But for
writing to msg->buf it would imply to write outside of the allocated buffer!
Do you agree to not change anything on this patch?
Thanks,
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-08-20 15:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 9:05 [PATCH v5 0/3] i2c-mv64xxx: Fixes and new feature for controlers embedded in Aramda XP Gregory CLEMENT
2013-08-09 9:05 ` [PATCH v5 1/3] i2c-mv64xxx: Add I2C Transaction Generator support Gregory CLEMENT
2013-08-15 12:13 ` Wolfram Sang
2013-08-20 15:56 ` Gregory CLEMENT [this message]
2013-08-21 21:01 ` Wolfram Sang
2013-08-22 7:40 ` Gregory CLEMENT
2013-08-22 9:06 ` Wolfram Sang
2013-08-09 9:05 ` [PATCH v5 2/3] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889) Gregory CLEMENT
2013-08-09 9:05 ` [PATCH v5 3/3] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c Gregory CLEMENT
2013-08-09 9:13 ` Ezequiel Garcia
2013-08-09 9:18 ` Gregory CLEMENT
2013-08-09 9:30 ` Ezequiel Garcia
2013-08-09 11:32 ` Jason Cooper
2013-08-20 16:21 ` [PATCH v5 0/3] i2c-mv64xxx: Fixes and new feature for controlers embedded in Aramda XP Gregory CLEMENT
2013-08-20 19:07 ` Wolfram Sang
2013-08-21 10:44 ` Gregory CLEMENT
2013-08-21 13:43 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52139192.5070507@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox