From: rogerq@ti•com (Roger Quadros)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 5/8] usb: musb: omap2430: Don't use omap_get_control_dev()
Date: Wed, 21 Aug 2013 09:41:51 +0300 [thread overview]
Message-ID: <5214612F.4000500@ti.com> (raw)
In-Reply-To: <5213AE04.1070907@cogentembedded.com>
On 08/20/2013 08:57 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 08/20/2013 06:56 PM, Roger Quadros wrote:
>
>> omap_get_control_dev() is being deprecated as it doesn't support
>> multiple instances. As control device is present only from OMAP4
>> onwards which supports DT only, we use phandles to get the
>> reference to the control device.
>
>> Also get rid of "ti,has-mailbox" property as it is redundant and
>> we can determine that from whether "ctrl-module" property is present
>> or not. Get rid of has_mailbox from musb_hdrc_platform_data as well.
>
>> Signed-off-by: Roger Quadros <rogerq@ti•com>
> [...]
>
>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
>> index ebb46ec..516795b 100644
>> --- a/drivers/usb/musb/omap2430.c
>> +++ b/drivers/usb/musb/omap2430.c
> [...]
>> @@ -509,8 +510,12 @@ static int omap2430_probe(struct platform_device *pdev)
>> glue->dev = &pdev->dev;
>> glue->musb = musb;
>> glue->status = OMAP_MUSB_UNKNOWN;
>> + glue->control_otghs = ERR_PTR(-ENODEV);
>
> Could you please align = with the others above?
OK.
cheers,
-roger
next prev parent reply other threads:[~2013-08-21 6:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 14:56 [PATCH v5 0/8] phy: omap-usb: Support multiple instances and new types Roger Quadros
2013-08-20 14:56 ` [PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data Roger Quadros
2013-08-20 15:04 ` thomas.langer at lantiq.com
2013-08-21 6:46 ` Roger Quadros
2013-08-20 14:56 ` [PATCH v5 2/8] usb: phy: omap: Add new device types and remove omap_control_usb3_phy_power() Roger Quadros
2013-08-20 14:56 ` [PATCH v5 3/8] usb: phy: omap-usb2: Don't use omap_get_control_dev() Roger Quadros
2013-08-20 14:56 ` [PATCH v5 4/8] usb: phy: omap-usb3: " Roger Quadros
2013-08-20 14:56 ` [PATCH v5 5/8] usb: musb: omap2430: " Roger Quadros
2013-08-20 17:57 ` Sergei Shtylyov
2013-08-21 6:41 ` Roger Quadros [this message]
2013-08-20 14:56 ` [PATCH v5 6/8] usb: phy: omap: get rid of omap_get_control_dev() Roger Quadros
2013-08-20 14:56 ` [PATCH v5 7/8] ARM: dts: omap4: update omap-control-usb nodes Roger Quadros
2013-08-20 14:56 ` [PATCH v5 8/8] ARM: dts: omap5: update omap-control-usb node Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214612F.4000500@ti.com \
--to=rogerq@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox