Subject: [PATCHv2 2/2] clocksource: dw_apb_timer_of: Fix read_sched_clock

From: [email-masked] (John Stultz)
Date: Wed, 21 Aug 2013 13:39:28 -0700

On 08/21/2013 01:02 PM, Dinh Nguyen wrote:
> On Wed, 2013-08-21 at 21:07 +0200, ZY - pavel wrote:
>> On Wed 2013-08-21 09:04:07, Linus Walleij wrote:
>>> On Thu, Aug 15, 2013 at 1:29 AM,  <[email-masked]> wrote:
>>>
>>>> -       sched_io_base = iobase + 0x04;
>>>> +       sched_io_base = iobase;
>>>>         sched_rate = rate;
>>>>  }
>>>>
>>>>  static u32 read_sched_clock(void)
>>>>  {
>>>> -       return __raw_readl(sched_io_base);
>>>> +       return ~__raw_readl(sched_io_base + 0x4);
>>> So what about #define what 0x04 is?
>>>
>>> #define MY_FOO_REGISTER_OFFSET 0x04
>>>
>>> raw_readl(sched_io_base + MY_FOO_REGISTER_OFFSET);
>> That define is already there, #define APBTMR_N_CURRENT_VALUE 0x04, but
>> it is in .c file, not in header.
> I'll send a V2 that will address this comment and Stephen Warren's.
Please be sure to CC Daniel Lezcano <[email-masked]> on
future versions as he's now maintaining the drivers/clocksource directory.

thanks
-john