public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: ldewangan@nvidia•com (Laxman Dewangan)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] ARM: tegra: add Palmas pincontrol to Dalmore device tree
Date: Thu, 22 Aug 2013 11:46:55 +0530	[thread overview]
Message-ID: <5215ACD7.9060400@nvidia.com> (raw)
In-Reply-To: <5214F8FD.3070003@wwwdotorg.org>

On Wednesday 21 August 2013 10:59 PM, Stephen Warren wrote:
> On 08/21/2013 06:34 AM, Laxman Dewangan wrote:
>> Add Palmas pincontrol to Dalmore device tree and make following
>> configuration as default:
>> - Disable DVFS1 and DVFS2.
>> - Set GPIO6 to gpio mode.
>> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
>> +			palmas_pinctrl {
>> +				compatible = "ti,tps65913-pinctrl";
> A node name of "pinmux" would be more appropriate here, since the node
> name should represent device type rather than device identity.
>
> Aside from that, the series looks fine, but at this point will have to
> wait for 3.13 I think, unless this series has a side-effect of fixing
> some bug/regression. Can you please repost once 3.12-rc1 is out?

Sure, I will correct the node name and post the patch later.

      reply	other threads:[~2013-08-22  6:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 12:34 [PATCH 1/2] ARM: tegra: enable PINCTRL_PALMAS config Laxman Dewangan
2013-08-21 12:34 ` [PATCH 2/2] ARM: tegra: add Palmas pincontrol to Dalmore device tree Laxman Dewangan
2013-08-21 17:29   ` Stephen Warren
2013-08-22  6:16     ` Laxman Dewangan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5215ACD7.9060400@nvidia.com \
    --to=ldewangan@nvidia$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox