From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 3/4] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c
Date: Fri, 23 Aug 2013 09:07:49 +0200 [thread overview]
Message-ID: <52170A45.9050006@free-electrons.com> (raw)
In-Reply-To: <20130822162241.GC31704@katana>
On 22/08/2013 18:22, Wolfram Sang wrote:
>
>> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
>> @@ -5,6 +5,8 @@ Required properties :
>>
>> - reg : Offset and length of the register set for the device
>> - compatible : Should be "marvell,mv64xxx-i2c" or "allwinner,sun4i-i2c"
>> + or for controller which support the I2C Transaction
>> + Generator "marvell,mv64xxx-i2c","marvell,mv7230-i2c"
>
> Too complicated IMO:
> + or "marvell,mv7230-i2c".
>
> DT creators don't need to know about transaction generators. They just
> supply the compatible string and the driver knows the details.
>
>> +For a controller which support the I2C Transaction Generator:
>
> "For the Armada XP" - there might be later IP cores on later SoC with
> transaction generators and different errata. They will just get a new
> compatible and the driver know the details.
You're right, I remained to close to my first version when it was a flag
and not a compatible name.
I will follow all your suggestions. A new version is coming soon.
Thanks,
>
>> +
>> + i2c at 11000 {
>> + compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
>> + reg = <0x11000 0x100>;
>> + interrupts = <29>;
>> + clock-frequency = <100000>;
>> + };
>> --
>> 1.8.1.2
>>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2013-08-23 7:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 14:19 [PATCH v6 3/4] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c Gregory CLEMENT
2013-08-22 14:19 ` [PATCH v6 4/4] ARM: dts: mvebu: Update with the " Gregory CLEMENT
2013-09-02 11:44 ` Gregory CLEMENT
2013-09-02 17:25 ` Jason Cooper
2013-09-03 12:36 ` Jason Cooper
2013-08-22 16:22 ` [PATCH v6 3/4] ARM: dts: mvebu: Introduce a " Wolfram Sang
2013-08-23 7:07 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52170A45.9050006@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox