public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 11/12] cpuidle: mvebu: Add initial cpu idle support for Armada 370/XP SoC
Date: Fri, 23 Aug 2013 10:41:53 +0200	[thread overview]
Message-ID: <52172051.2030505@free-electrons.com> (raw)
In-Reply-To: <1377240797-4047-12-git-send-email-gregory.clement@free-electrons.com>

On 23/08/2013 08:53, Gregory CLEMENT wrote:
> Add wfi/cpu idle/cpu deep idle power states support for Armada XP SoC.
> 
> All the latencies and the power consumption values used at the
> "armada_370_xp_idle_driver" structure are preliminary and will be
> modified in the future after running some measurements and analysis.
> 
> Based on the work of Nadav Haklai.

Atsushi Yamagata reported me an kernel crash when pm_support=off.
Indeed I have lost a small chunk of code during my code reshaping.
The following code will fix the issue. I will add it in the next
version of this series.

[...]
> +
> +	if (pm_support == WFI)
> +		pr_info(" (WFI)\n");
> +	else if (pm_support == MV_CPU_IDLE)
> +		pr_info(" (CPU_IDLE)\n");
> +	else if (pm_support == MV_CPU_DEEP_IDLE)
> +		pr_info(" (CPU_DEEP_IDLE)\n");


> +	else
> +		pr_info(" (DISABLED)\n");
Will be replaced by
+       else {
+                       pr_info(" (DISABLED)\n");
+                       return; /* do not register the cpuidle device */
+       }

> +
> +	armada_370_xp_idle_driver.state_count = pm_support + 1;
> +
> +	return cpuidle_register(&armada_370_xp_idle_driver, NULL);
> +}
> +

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-08-23  8:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23  6:53 [PATCH 00/12] CPU idle for Armada XP Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 01/12] ARM: PJ4B: Add cpu_suspend/cpu_resume hooks for PJ4B Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 02/12] ARM: mvebu: ll_set_cpu_coherent no more uses the coherency address as parameter Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 03/12] ARM: mvebu: ll_set_cpu_coherent always uses the current CPU Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 04/12] ARM: mvebu: Remove the unused argument of set_cpu_coherent() Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 05/12] ARM: mvebu: Makes ll_set_cpu_coherent() more configurable Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 06/12] ARM: mvebu: Low level functions to disbale cache snooping Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 07/12] ARM: mvebu: Add a new set of registers for pmsu Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 08/12] ARM: mvebu: Allow to power down L2 cache controller in idle mode Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 09/12] ARM: mvebu: Add the PMSU related part of the cpu idle functions Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 10/12] ARM: mvebu: Set the start address of a CPU in a separate function Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 11/12] cpuidle: mvebu: Add initial cpu idle support for Armada 370/XP SoC Gregory CLEMENT
2013-08-23  8:41   ` Gregory CLEMENT [this message]
2013-08-27  3:28   ` Kevin Hilman
2013-08-28  6:37     ` Gregory CLEMENT
2013-08-23  6:53 ` [PATCH 12/12] ARM: dts: mvebu: Add a new set of registers to the PMSU node Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52172051.2030505@free-electrons.com \
    --to=gregory.clement@free-electrons$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox