From: sebastian.hesselbarth@gmail•com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 7/7] watchdog: orion: Update device-tree binding documentation
Date: Fri, 23 Aug 2013 14:57:05 +0200 [thread overview]
Message-ID: <52175C21.603@gmail.com> (raw)
In-Reply-To: <20130823125311.GH2389@localhost>
On 08/23/13 14:53, Ezequiel Garcia wrote:
> On Fri, Aug 23, 2013 at 07:04:51AM -0300, Ezequiel Garcia wrote:
>> On Thu, Aug 22, 2013 at 09:26:21PM -0400, Jason Cooper wrote:
>>> On Thu, Aug 22, 2013 at 11:41:58AM -0300, Ezequiel Garcia wrote:
>>>> diff --git a/Documentation/devicetree/bindings/watchdog/orion-wdt.txt b/Documentation/devicetree/bindings/watchdog/orion-wdt.txt
>>>> index 5dc8d30..bb7f1a2 100644
>>>> --- a/Documentation/devicetree/bindings/watchdog/orion-wdt.txt
>>>> +++ b/Documentation/devicetree/bindings/watchdog/orion-wdt.txt
>>>> @@ -13,7 +16,9 @@ Example:
>>>>
>>>> wdt at 20300 {
>>>> compatible = "marvell,orion-wdt";
>>>> - reg = <0x20300 0x28>;
>>>> + reg = <0x20300 0x4
>>>> + 0x20324 0x4
>>>> + 0x20108 0x4>;
>>>
>>> I don't like this. It reaches outside of the wdt register. I think a
>>> more clean way to do this is to do a provider/consumer relationship as
>>> in reset.txt. eg, here you would retain the original reg binding, and
>>> add a reset phandle.
>>
>> Mmm... I can't see how this fits a reset-controller usage.
>>
>> The watchdog simply "enables" the RSTOUT bit that allows the whole SoC
>> to be reset when the watchdog counter expires.
>>
>> The reset-controller seems to be meant to send reset signals to devices,
>> which is not this case.
>>
>> What am I missing?
>
> Another possible solution is to simply "enable" the RSTOUT bit for
> watchdog somewhere in mach-{kirkwood,mvebu,...} at board boot-up time.
>
> Do you think that would have any drawbacks?
IMHO, it should be fine to always enable watchdog reset -> rstout_n
assertion. The watchdog driver does it unconditionally anyway.
We can move it to arch specific code now, and reset API handler later.
Sebastian
next prev parent reply other threads:[~2013-08-23 12:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 14:41 [PATCH 0/7] Orion watchdog DT changes to support more SoCs Ezequiel Garcia
2013-08-22 14:41 ` [PATCH 1/7] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Ezequiel Garcia
2013-08-22 14:41 ` [PATCH 2/7] watchdog: orion: Make counter register a separate resource Ezequiel Garcia
2013-08-22 14:41 ` [PATCH 3/7] watchdog: orion: Make RSTOUT " Ezequiel Garcia
2013-08-22 14:41 ` [PATCH 4/7] watchdog: orion: Allow to build in any Orion platform Ezequiel Garcia
2013-08-22 14:41 ` [PATCH 5/7] ARM: kirkwood: Update watchdog 'reg' property Ezequiel Garcia
2013-08-22 14:41 ` [PATCH 6/7] watchdog: orion: Rename device-tree binding documentation Ezequiel Garcia
2013-08-22 14:41 ` [PATCH 7/7] watchdog: orion: Update " Ezequiel Garcia
2013-08-23 1:26 ` Jason Cooper
2013-08-23 10:04 ` Ezequiel Garcia
2013-08-23 12:53 ` Ezequiel Garcia
2013-08-23 12:57 ` Sebastian Hesselbarth [this message]
2013-08-23 13:07 ` Ezequiel Garcia
2013-08-26 14:00 ` Jason Cooper
2013-08-23 1:07 ` [PATCH 0/7] Orion watchdog DT changes to support more SoCs Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52175C21.603@gmail.com \
--to=sebastian.hesselbarth@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox