From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string
Date: Fri, 23 Aug 2013 13:19:31 -0400 [thread overview]
Message-ID: <521799A3.7080706@ti.com> (raw)
In-Reply-To: <5217974B.5090503@ti.com>
On Friday 23 August 2013 01:09 PM, Sekhar Nori wrote:
>
>
> On 8/23/2013 10:26 PM, Santosh Shilimkar wrote:
>> On Friday 23 August 2013 12:30 PM, Daniel Mack wrote:
>>> On 23.08.2013 16:23, Santosh Shilimkar wrote:
>>>> On Friday 23 August 2013 10:16 AM, Daniel Mack wrote:
>>>
>>>>> +static const struct of_device_id cpsw_of_mtable[] = {
>>>>> + {
>>>>> + .compatible = "ti,am3352-cpsw",
>>>>
>>>> I didn't notice this earlier, but can't you use the IP version
>>>> as a compatible instead of using a SOC name. Whats really SOC specific
>>>> on this IP ? Sorry i have missed any earlier discussion on this but
>>>> this approach doesn't seem good. Its like adding SOC checks in the
>>>> driver subsystem.
>>>
>>> As I already mentioned in the cover letter and in the commit message, I
>>> just don't know which criteria makes most sense here.
>>>
>>> On a general note, I would say that chances that this exactly IP core
>>> with the same version number will appear on some other silicon which
>>> doesn't support the control mode register in an AM33xx fashion, is not
>>> necessarily negligible.
>>>
>>> So what that new compatible string denotes is the cpsw in a version as
>>> found on am3352 SoCs, which is actually exactly what it does.
>>>
>>> I don't have a strong opinion here, but see your point. I just don't
>>> have a better idea on how to treat that.
>>>
>> So just stick the IP version or call it cpsw-v1... cpsw-v2 etc.
>
> If this could be handled using IP version then the right way would be to
> just read the IP version from hardware and use it. No need of DT property.
>
Thats fine as well but I thought the patch needed additional properties like
CM reg-address come from DT and hence the separate compatible. If you can
manage without that, thats even better.
Regards,
Santosh
next prev parent reply other threads:[~2013-08-23 17:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 14:16 [PATCH v4 0/5] cpsw: support for control module register Daniel Mack
2013-08-23 14:16 ` [PATCH v4 1/5] net: ethernet: cpsw: switch to devres allocations Daniel Mack
2013-08-23 18:10 ` Sergei Shtylyov
2013-08-23 18:34 ` Daniel Mack
2013-08-23 14:16 ` [PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module Daniel Mack
2013-08-23 14:59 ` Sergei Shtylyov
2013-08-23 16:21 ` Daniel Mack
2013-08-23 17:37 ` Sergei Shtylyov
2013-08-23 14:16 ` [PATCH v4 3/5] net: ethernet: cpsw: introduce ti, am3352-cpsw compatible string Daniel Mack
2013-08-23 14:23 ` [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw " Santosh Shilimkar
2013-08-23 15:22 ` Benoit Cousson
2013-08-23 15:54 ` Santosh Shilimkar
2013-08-23 16:30 ` Daniel Mack
2013-08-23 16:56 ` Santosh Shilimkar
2013-08-23 17:09 ` Sekhar Nori
2013-08-23 17:17 ` Daniel Mack
2013-08-23 17:19 ` Santosh Shilimkar [this message]
2013-08-23 17:24 ` Daniel Mack
2013-08-23 17:28 ` Santosh Shilimkar
2013-08-23 17:39 ` Sekhar Nori
2013-08-23 18:10 ` Santosh Shilimkar
2013-08-23 18:29 ` Mugunthan V N
2013-08-23 19:54 ` Santosh Shilimkar
2013-08-26 5:59 ` Mugunthan V N
2013-08-26 6:45 ` Sekhar Nori
2013-08-23 17:23 ` Mugunthan V N
2013-08-26 5:22 ` Gupta, Pekon
2013-08-23 16:31 ` Sekhar Nori
2013-08-23 16:45 ` Mugunthan V N
2013-08-23 17:05 ` Santosh Shilimkar
2013-08-23 14:16 ` [PATCH v4 4/5] net: ethernet: cpsw: add support for hardware interface mode config Daniel Mack
2013-08-23 16:50 ` Mugunthan V N
2013-08-23 14:16 ` [PATCH v4 5/5] ARM: dts: am33xx: adopt to cpsw changes Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521799A3.7080706@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox