From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 4/5] net: ethernet: cpsw: add support for hardware interface mode config
Date: Fri, 23 Aug 2013 23:18:05 +0400 [thread overview]
Message-ID: <5217B56D.1010608@cogentembedded.com> (raw)
In-Reply-To: <1377283987-20040-5-git-send-email-zonque@gmail.com>
On 08/23/2013 10:53 PM, Daniel Mack wrote:
> The cpsw currently lacks code to properly set up the hardware interface
> mode on AM33xx. Other platforms might be equally affected.
> Usually, the bootloader will configure the control module register, so
> probably that's why such support wasn't needed in the past. In suspend
> mode though, this register is modified, and so it needs reprogramming
> after resume.
> This patch adds code that makes use of the previously added and optional
> support for passing the control mode register, and configures the
> correct register bits when the slave is opened.
> The AM33xx also has a bit for each slave to configure the RMII reference
> clock direction. Setting it is now supported by a per-slave DT property.
> This code path introducted by this patch is currently exclusive for
> am33xx.
> Signed-off-by: Daniel Mack <zonque@gmail•com>
[...]
> @@ -40,4 +41,11 @@ struct cpsw_platform_data {
> u32 hw_type; /* hardware type as specified in 'compatible' */
> };
>
> +/* SoC specific definitions for the CONTROL port */
> +#define AM33XX_GMII_SEL_MODE_MII (0)
> +#define AM33XX_GMII_SEL_MODE_RMII (1)
> +#define AM33XX_GMII_SEL_MODE_RGMII (2)
Parens around decimal literals are hardly needed even in macros.
WBR, Sergei
next prev parent reply other threads:[~2013-08-23 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 18:53 [PATCH v5 0/5] cpsw: support for control module register Daniel Mack
2013-08-23 18:53 ` [PATCH v5 1/5] net: ethernet: cpsw: switch to devres allocations Daniel Mack
2013-08-23 18:53 ` [PATCH v5 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module Daniel Mack
2013-08-23 19:10 ` Sergei Shtylyov
2013-08-23 19:14 ` Daniel Mack
2013-08-23 18:53 ` [PATCH v5 3/5] net: ethernet: cpsw: introduce ti, am3352-cpsw compatible string Daniel Mack
2013-08-23 18:53 ` [PATCH v5 4/5] net: ethernet: cpsw: add support for hardware interface mode config Daniel Mack
2013-08-23 19:18 ` Sergei Shtylyov [this message]
2013-08-23 18:53 ` [PATCH v5 5/5] ARM: dts: am33xx: adopt to cpsw changes Daniel Mack
2013-08-23 19:13 ` [PATCH v5 0/5] cpsw: support for control module register Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5217B56D.1010608@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox