From: rnayak@ti•com (Rajendra Nayak)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] ARM: OMAP4+: Move SRAM data to DT
Date: Thu, 29 Aug 2013 16:32:52 +0530 [thread overview]
Message-ID: <521F2A5C.80404@ti.com> (raw)
In-Reply-To: <521DCFD8.2020304@ti.com>
On Wednesday 28 August 2013 03:54 PM, Sekhar Nori wrote:
> On Wednesday 28 August 2013 11:53 AM, Rajendra Nayak wrote:
>> On Tuesday 27 August 2013 04:53 PM, Sekhar Nori wrote:
>>> On Tuesday 27 August 2013 03:41 PM, Rajendra Nayak wrote:
>>>> Use drivers/misc/sram.c driver to manage SRAM on all DT only
>>>> OMAP platforms (am33xx, am43xx, omap4 and omap5) instead of
>>>> the existing private implementation.
>>>>
>>>> Address and size related data is removed from mach-omap2/sram.c
>>>> and now passed to drivers/misc/sram.c from DT.
>>>>
>>>> Users can hence use general purpose allocator apis instead of
>>>> OMAP private ones to manage and use SRAM.
>>>>
>>>> Currently there are no users on SRAM on these platfoms.
>>>>
>>>> Signed-off-by: Rajendra Nayak <rnayak@ti•com>
>>>
>>> Nice getting rid of code.
>>>
>>>> diff --git a/arch/arm/mach-omap2/sram.h b/arch/arm/mach-omap2/sram.h
>>>> index ca7277c..3f83b80 100644
>>>> --- a/arch/arm/mach-omap2/sram.h
>>>> +++ b/arch/arm/mach-omap2/sram.h
>>>> @@ -80,4 +80,3 @@ static inline void omap_push_sram_idle(void) {}
>>>> #else
>>>> #define OMAP4_SRAM_PA 0x40300000
>>>> #endif
>>>> -#define AM33XX_SRAM_PA 0x40300000
>>>
>>> I guess OMAP4_SRAM_PA is left in the code to take care of errata I688?
>>
>> right.
>>
>>> How about removing the iotable entry for SRAM on OMAP4 and converting
>>> omap_barriers_init() to use the gen_pool API instead of passing an
>>> incremented address to DT?
>>
>> Actually we dont really need to alloc and manage any sram pool for handling
>> the errata. It just needs to know an sram location which it can read and write
>> back into (which can be any sram location used/unused).
>
> But there will be a race with other writes to SRAM since omap_bus_sync()
> is not atomic context.
Right, I completely overlooked the fact that omap_bus_sync() is also done every
wmb(). I was thinking its needed only just before a wfi.
I will repost a v2 using gen_pool to allocate sram space to handle errata I688
and get rid of all the static mappings.
regards,
Rajendra
>
> Thanks,
> Sekhar
>
next prev parent reply other threads:[~2013-08-29 11:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 10:11 [PATCH 0/2] OMAP4+: Get rid of internal SRAM handling Rajendra Nayak
2013-08-27 10:11 ` [PATCH 1/2] ARM: AM335x: Get rid of unused sram init function Rajendra Nayak
2013-08-27 16:06 ` Dave Gerlach
2013-08-28 6:17 ` Rajendra Nayak
2013-08-27 10:11 ` [PATCH 2/2] ARM: OMAP4+: Move SRAM data to DT Rajendra Nayak
2013-08-27 11:23 ` Sekhar Nori
2013-08-28 6:23 ` Rajendra Nayak
2013-08-28 10:24 ` Sekhar Nori
2013-08-29 11:02 ` Rajendra Nayak [this message]
2013-09-03 13:56 ` Russ Dill
2013-09-03 14:35 ` Lucas Stach
2013-09-03 15:07 ` Russ Dill
2013-08-27 13:25 ` [PATCH 0/2] OMAP4+: Get rid of internal SRAM handling Santosh Shilimkar
2013-08-28 6:29 ` Rajendra Nayak
2013-08-28 13:38 ` Santosh Shilimkar
2013-08-28 13:42 ` Rajendra Nayak
2013-08-28 14:46 ` Santosh Shilimkar
2013-10-08 18:34 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F2A5C.80404@ti.com \
--to=rnayak@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox