From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] media: i2c: adv7343: fix the DT binding properties
Date: Fri, 13 Sep 2013 16:46:52 -0600 [thread overview]
Message-ID: <523395DC.5080009@wwwdotorg.org> (raw)
In-Reply-To: <1379073471-7244-1-git-send-email-prabhakar.csengg@gmail.com>
On 09/13/2013 05:57 AM, Prabhakar Lad wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail•com>
>
> This patch fixes the DT binding properties of adv7343 decoder.
> The pdata which was being read from the DT property, is removed
> as this can done internally in the driver using cable detection
> register.
>
> This patch also removes the pdata of ADV7343 which was passed from
> DA850 machine.
> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7343.txt b/Documentation/devicetree/bindings/media/i2c/adv7343.txt
> Required Properties :
> - compatible: Must be "adi,adv7343"
> +- reg: I2C device address.
> +- vddio-supply: I/O voltage supply.
> +- vddcore-supply: core voltage supply.
> +- vaa-supply: Analog power supply.
> +- pvdd-supply: PLL power supply.
Old DTs won't contain those properties. This breaks the DT ABI if those
properties are required. Is that acceptable?
If it is, I think we should document that older versions of the binding
didn't require those properties, so they may in fact be missing.
I note that this patch doesn't actually update the driver to
regulator_get() anything. Shouldn't it?
> Optional Properties :
> -- adi,power-mode-sleep-mode: on enable the current consumption is reduced to
> - micro ampere level. All DACs and the internal PLL
> - circuit are disabled.
> -- adi,power-mode-pll-ctrl: PLL and oversampling control. This control allows
> - internal PLL 1 circuit to be powered down and the
> - oversampling to be switched off.
> -- ad,adv7343-power-mode-dac: array configuring the power on/off DAC's 1..6,
> - 0 = OFF and 1 = ON, Default value when this
> - property is not specified is <0 0 0 0 0 0>.
> -- ad,adv7343-sd-config-dac-out: array configure SD DAC Output's 1 and 2, 0 = OFF
> - and 1 = ON, Default value when this property is
> - not specified is <0 0>.
At a very quick glance, it's not really clear why those properties are
being removed. They seem like HW configuration, so might be fine to put
into DT. What replaces these?
next parent reply other threads:[~2013-09-13 22:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1379073471-7244-1-git-send-email-prabhakar.csengg@gmail.com>
2013-09-13 22:46 ` Stephen Warren [this message]
2013-09-14 5:23 ` [PATCH] media: i2c: adv7343: fix the DT binding properties Prabhakar Lad
2013-09-16 16:24 ` Stephen Warren
2013-09-19 16:06 ` Prabhakar Lad
2013-09-19 19:49 ` Sylwester Nawrocki
2013-09-20 8:11 ` Prabhakar Lad
2013-09-20 9:52 ` Sylwester Nawrocki
2013-09-23 2:48 ` Prabhakar Lad
2013-09-23 11:50 ` Laurent Pinchart
2013-09-23 21:33 ` Stephen Warren
2013-09-24 6:15 ` Prabhakar Lad
2013-09-24 9:44 ` Laurent Pinchart
2013-09-24 15:52 ` Mark Brown
2013-09-24 15:54 ` Mark Brown
2013-09-30 13:27 ` Prabhakar Lad
2013-09-30 14:41 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523395DC.5080009@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox