From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/2] video: ARM CLCD: Add DT support
Date: Mon, 16 Sep 2013 13:52:32 -0600 [thread overview]
Message-ID: <52376180.1090001@wwwdotorg.org> (raw)
In-Reply-To: <1379351934-25415-1-git-send-email-pawel.moll@arm.com>
On 09/16/2013 11:18 AM, Pawel Moll wrote:
> This patch adds basic DT bindings for the PL11x CLCD controllers
> and make their fbdev driver use them (initially only TFT panels
> are supported).
> diff --git a/Documentation/devicetree/bindings/video/arm,pl11x.txt b/Documentation/devicetree/bindings/video/arm,pl11x.txt
> +- interrupts: either a single interrupt specifier representing the
> + combined interrupt output (CLCDINTR) or an array of
> + four interrupt specifiers for CLCDMBEINTR,
> + CLCDVCOMPINTR, CLCDLNBUINTR, CLCDFUFINTR; in the
> + latter case interrupt names must be specified
> + (see below)
> +- interrupt-names: when four interrupts are specified, their names:
> + "mbe", "vcomp", "lnbu", "fuf"
> + must be specified in order respective to the
> + interrupt specifiers
I think the binding should either always use names as the key, or use
indices in interrupts as the key. Hence, I'd word that more like:
- interrupt-names: either the single entry "combined" representing a
combined interrupt output (CLCDINTR), or the
four entries "mbe", "vcomp", "lnbu", "fuf"
representing the individual CLCDMBEINTR,
CLCDVCOMPINTR, CLCDLNBUINTR, CLCDFUFINTR
interrupts.
- interrupts: contains an interrupt specifier for each entry in
interrupt-names.
> +- arm,pl11x,panel-data-pads: array of 24 cells, each of them describing
> + a function of one of the CLD pads,
> + starting from 0 up to 23; each pad can
> + be described by one of the following values:
> + - 0: reserved (not connected)
> + - 0x100-0x107: color upper STN panel data 0 to 7
...
I assume those are the raw values that go into the HW?
> + Example sets of values for standard
> + panel interfaces:
> + - PL110 single colour STN panel:
> + <0x107 0x106 0x105 0x104 0x103 0x102 0x101 0x100>,
> + <0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0>;
The indentation of the introductory text seems a little odd. Do we
really need so many examples?
> +Optional properties:
> +
> +- arm,pl11x,framebuffer-base: a pair of two values, address and size,
> + defining the framebuffer to be used;
> + to be used only if it is *not*
> + part of normal memory, as described
> + in /memory node
If the framebuffer is part of /memory, what happens then? Is the address
not fixed (so the HW isn't yet set up) and hence a driver should
allocate it?
next prev parent reply other threads:[~2013-09-16 19:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 17:18 [PATCH v3 1/2] video: ARM CLCD: Add DT support Pawel Moll
2013-09-16 17:18 ` [PATCH v3 2/2] ARM: vexpress: Add CLCD Device Tree properties Pawel Moll
2013-09-16 19:52 ` Stephen Warren [this message]
2013-09-17 16:36 ` [PATCH v3 1/2] video: ARM CLCD: Add DT support Pawel Moll
2013-09-17 16:51 ` Pawel Moll
2013-09-17 21:34 ` Stephen Warren
2013-09-17 21:38 ` Stephen Warren
2013-09-18 16:39 ` Pawel Moll
2013-09-23 16:03 ` Stephen Warren
2013-09-23 16:06 ` Russell King - ARM Linux
2013-09-23 16:30 ` Stephen Warren
2013-09-23 16:43 ` Russell King - ARM Linux
2013-09-23 19:52 ` Stephen Warren
2013-09-23 20:29 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52376180.1090001@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox