From: mikedunn@newsguy•com (Mike Dunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3] PWM: PXA: add device tree support to PWM driver
Date: Tue, 17 Sep 2013 07:07:25 -0700 [thread overview]
Message-ID: <5238621D.3050504@newsguy.com> (raw)
In-Reply-To: <52375FB1.5050700@wwwdotorg.org>
On 09/16/2013 12:44 PM, Stephen Warren wrote:
> On 09/13/2013 10:54 AM, Mike Dunn wrote:
>> This patch adds device tree support to the PXA's PWM driver. Only an OF match
>> table is added; nothing needs to be extracted from the device tree node. The
>> existing ID table is reused for the match table data.
>>
>> Tested on a Palm Treo 680 (both platform data and DT cases).
>
>> diff --git a/Documentation/devicetree/bindings/pwm/pxa-pwm.txt b/Documentation/devicetree/bindings/pwm/pxa-pwm.txt
>
>> +- compatible: should be one of:
>> + - "marvell,pxa250-pwm"
>> + - "marvell,pxa270-pwm"
>> + - "marvell,pxa168-pwm"
>> + - "marvell,pxa910-pwm"
>
> Not just one of, but possible more than one...
So the phrasing should be "compatible: should be among:" ?
>
>> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
>
>> + pwm0: pwm at 40b00000 {
>> + compatible = "marvell,pxa270-pwm";
>
> I thought the assertion was that pax270 and pxa250 were both compatible?
> If so, that should be:
>
> compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm";
Indeed. Currently, they are all the same. By that logic, shouldn't it be
compatible = "marvell,pxa250-pwm", "marvell,pxa270-pwm", "marvell,pxa168-pwm",
"marvell,pxa910-pwm";
I am admittedly fuzzy on device tree, but this is starting to seem strange.
Anyway, I'll defer to your judgement and resubmit if you can give me precise
guidance on the above. Thanks again for the review.
Thanks,
Mike
next prev parent reply other threads:[~2013-09-17 14:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 16:54 [PATCH v3] PWM: PXA: add device tree support to PWM driver Mike Dunn
2013-09-15 14:07 ` Marek Vasut
2013-09-16 14:42 ` Mike Dunn
2013-09-16 15:10 ` Marek Vasut
2013-09-16 19:45 ` Stephen Warren
2013-09-16 23:00 ` Marek Vasut
2013-09-16 19:44 ` Stephen Warren
2013-09-16 23:01 ` Marek Vasut
2013-09-16 23:03 ` Stephen Warren
2013-09-17 14:07 ` Mike Dunn [this message]
2013-09-17 16:17 ` Stephen Warren
2013-09-17 18:56 ` Mike Dunn
2013-09-17 19:26 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5238621D.3050504@newsguy.com \
--to=mikedunn@newsguy$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox