From: nm@ti•com (Nishanth Menon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] PM / OPP: rename functions to dev_pm_opp*
Date: Fri, 20 Sep 2013 14:07:17 -0500 [thread overview]
Message-ID: <523C9CE5.9040009@ti.com> (raw)
In-Reply-To: <CAKohpoktS4ZSQAeKvu3hdVsKkzcbKFvHvR2=wCA3qeB6moPphA@mail.gmail.com>
On 09/20/2013 11:51 AM, Viresh Kumar wrote:
> On 20 September 2013 18:08, Nishanth Menon <nm@ti•com> wrote:
>
>> I am open to suggestions if any one feels we can improve this better.
>
> I didn't really had one.. I thought of pm_opp** instead of dev_pm_opp**
> though..
I had proposed this earlier, however, had gone with Rafael's
suggestion [1] to have the right context to the usage.
>
>> I believe that change was from Patch #2[1]
>
> Yeah.. I just replied on a single patch :)
>
>> yes, you are right, I had squashed this patch in to squelch checkpatch
>> warnings:
>
> I see..
>
>> I had added a comment:
>> " Minor checkpatch warning fixes as a result of this change was fixed as
>> well."
>
> I really missed that..
no problems..
>
>> Would you suggest I split the change off to a separate patch or improve
>> the comment a little more?
>
> don't really know, maybe leave those as is and let checkpatch warn you..
>
that is fair as well. i can split it off seperately in the next respin.
[1] http://marc.info/?l=linaro-kernel&m=137645747511725&w=2
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-09-20 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 21:03 [PATCH 0/3] PM / OPP: rename to dev_pm_opp * equivalents Nishanth Menon
2013-09-19 21:03 ` [PATCH 1/3] PM / OPP: rename functions to dev_pm_opp* Nishanth Menon
2013-09-20 7:14 ` Viresh Kumar
2013-09-20 12:38 ` Nishanth Menon
2013-09-20 16:51 ` Viresh Kumar
2013-09-20 19:07 ` Nishanth Menon [this message]
2013-09-19 21:03 ` [PATCH 2/3] PM / OPP: rename data structures to dev_pm equivalents Nishanth Menon
2013-09-19 21:03 ` [PATCH 3/3] PM / OPP: rename header to linux/pm_opp.h Nishanth Menon
2013-09-19 21:14 ` [PATCH 0/3] PM / OPP: rename to dev_pm_opp * equivalents Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523C9CE5.9040009@ti.com \
--to=nm@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox