From: linux@roeck-us•net (Guenter Roeck)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] Add smp support for Allwinner A20(sunxi 7i).
Date: Sun, 22 Sep 2013 20:37:23 -0700 [thread overview]
Message-ID: <523FB773.4050408@roeck-us.net> (raw)
In-Reply-To: <20130921140059.GA2779@lukather>
On 09/21/2013 07:00 AM, Maxime Ripard wrote:
[ ... ]
>> + /* assert cpu core reset */
>> + writel(0, sunxi7i_cc_base + CPUX_RESET_CTL(cpu));
>> + /* L1RSTDISABLE hold low */
>> + pwr_reg = readl(sunxi7i_cc_base + AW_CPUCFG_GENCTL);
>> + pwr_reg &= ~(1<<cpu);
>> + writel(pwr_reg, sunxi7i_cc_base + AW_CPUCFG_GENCTL);
>> + /* DBGPWRDUP hold low */
>> + pwr_reg = readl(sunxi7i_cc_base + AW_CPUCFG_DBGCTL1);
>> + pwr_reg &= ~(1<<cpu);
>
> Use BIT(cpu) here. And you should run scripts/checkpatch.pl on your
> patches before sending them.
>
For the record:
$ scripts/checkpatch.pl --strict allwinner.patch
total: 0 errors, 0 warnings, 0 checks, 527 lines checked
allwinner.patch has no obvious style problems and is ready for submission.
This is on top of "v3.12-rc1-336-gd8524ae".
checkpatch.pl does not complain as long as the number of spaces before
and after an operator is the same. There is a patch pending to change
this with the --strict option, but it will still not complain in 'normal'
operation.
Guenter
next prev parent reply other threads:[~2013-09-23 3:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 13:05 [PATCH 0/3] Fan Rong
2013-09-21 13:05 ` [PATCH 1/3] Add smp support for Allwinner A20(sunxi 7i) Fan Rong
2013-09-21 13:31 ` Russell King - ARM Linux
2013-09-21 14:00 ` Maxime Ripard
2013-09-21 16:49 ` cinifr
2013-09-21 17:15 ` Russell King - ARM Linux
2013-09-21 22:49 ` Maxime Ripard
2013-09-23 7:03 ` Uwe Kleine-König
2013-09-23 3:37 ` Guenter Roeck [this message]
2013-09-23 18:19 ` Maxime Ripard
2013-09-23 18:56 ` Guenter Roeck
2013-09-21 13:05 ` [PATCH 2/3] Add cpuconfig nodes in dts for smp configure Fan Rong
2013-09-21 13:05 ` [PATCH 3/3] Add arch count timer node in dts for Allwinner A20(sunxi 7i) Fan Rong
-- strict thread matches above, loose matches on Subject: below --
2013-09-22 12:21 [PATCH V3: Add Smp support for Allwinner A20. 0/3] Fan Rong
2013-09-22 12:21 ` [PATCH V3: Add Smp support for Allwinner A20. 1/3] Add smp support for Allwinner A20(sunxi 7i) Fan Rong
2013-09-22 14:44 ` [linux-sunxi] " Ian Campbell
[not found] ` <CAK3cCBzMXdeeSPC-OpWcHAuef=ocpy5n0=Fc2yBECPnU=2OTXw@mail.gmail.com>
2013-09-23 7:18 ` [PATCH " Ian Campbell
2013-09-23 14:43 ` cinifr
2013-09-23 18:34 ` maxime.ripard at free-electrons.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523FB773.4050408@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox