From: zonque@gmail•com (Daniel Mack)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RESEND] ARM: pxa: ssp: remove kfree for memory allocated with devm_kzalloc
Date: Tue, 24 Sep 2013 10:54:59 +0200 [thread overview]
Message-ID: <52415363.5020009@gmail.com> (raw)
In-Reply-To: <CAPgLHd9T5_auqA_4Ev_Qh6f_vZONqc8z6AcJVuV1S0VkFn4S_Q@mail.gmail.com>
On 24.09.2013 05:35, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
>
> It's not necessary to free memory allocated with devm_kzalloc
> and using kfree leads to a double free.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
Acked-by: Daniel Mack <zonque@gmail•com>
Chao Xie wanted to work on getting rid of the "middle layer" the pxa ssp
driver has. If that's going to happen for 3.13, it will again affect
both the ASoC part and code in arch/arm. Therefore, I would again prefer
if ssp patches went through Mark's ASoC tree. Chao, are you still
planning to work on this?
Daniel
> ---
> arch/arm/plat-pxa/ssp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
> index 3ea0290..528143e 100644
> --- a/arch/arm/plat-pxa/ssp.c
> +++ b/arch/arm/plat-pxa/ssp.c
> @@ -250,7 +250,6 @@ static int pxa_ssp_remove(struct platform_device *pdev)
> list_del(&ssp->node);
> mutex_unlock(&ssp_lock);
>
> - kfree(ssp);
> return 0;
> }
>
>
next prev parent reply other threads:[~2013-09-24 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 3:35 [PATCH RESEND] ARM: pxa: ssp: remove kfree for memory allocated with devm_kzalloc Wei Yongjun
2013-09-24 8:54 ` Daniel Mack [this message]
2013-09-27 2:15 ` Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52415363.5020009@gmail.com \
--to=zonque@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox