From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] spi: davinci: Allow SPI to be build without EDMA support
Date: Mon, 30 Sep 2013 11:23:48 -0400 [thread overview]
Message-ID: <52499784.9040906@ti.com> (raw)
In-Reply-To: <20130930143848.GB19304@sirena.org.uk>
On Monday 30 September 2013 10:38 AM, Mark Brown wrote:
> On Mon, Sep 30, 2013 at 09:36:23AM -0400, Santosh Shilimkar wrote:
>> On Sunday 29 September 2013 08:31 AM, Mark Brown wrote:
>
>>> If there's no hard dependency on EDMA then the driver probably ought to
>>> be marked as COMPILE_TEST so that it can be build tested on other
>>> systems. Is that possible?
>
>> EDMA is already getting tested for DAVINCI builds and there are patches
>> coming AMXXXX SOC support. So probably marking it COMPILE_TEST isn't
>> needed since it has been in use already for other SOCs.
>
> It'd make life easier for general subsystem development if we were able
> to get build coverage without having to build a specific config, even if
> it's never actually going to be run.
>
So after your comments, I actually checked whether the driver works with
EDMA enabled but no EDMA node/data information from DT for SPI driver.
It seems to work.
So I am going to drop this patch and rather allow the EDMA to be built
for Keystone SOCs as well. Not sure why I didn't looked at this as an
option first place.
Thanks for your comments Mark.
Regards,
Santosh
next prev parent reply other threads:[~2013-09-30 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 23:42 [PATCH 0/4] ARM: keystone: Enable SPI and I2C support Santosh Shilimkar
2013-09-27 23:42 ` [PATCH 1/4] ARM: dts: keystone: Add i2c device nodes Santosh Shilimkar
2013-09-27 23:42 ` [PATCH 2/4] ARM: dts: keystone: Add the SPI nodes Santosh Shilimkar
2013-09-27 23:42 ` [PATCH 3/4] spi: davinci: Allow SPI to be build without EDMA support Santosh Shilimkar
2013-09-29 12:31 ` Mark Brown
2013-09-30 13:36 ` Santosh Shilimkar
2013-09-30 14:38 ` Mark Brown
2013-09-30 15:23 ` Santosh Shilimkar [this message]
2013-09-27 23:42 ` [PATCH 4/4] ARM: keystone: Enable I2C and SPI bus support Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52499784.9040906@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox