From: rogerq@ti•com (Roger Quadros)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ahci: exynos: add ahci sata support on Exynos platform
Date: Tue, 8 Oct 2013 14:59:29 +0300 [thread overview]
Message-ID: <5253F3A1.8090906@ti.com> (raw)
In-Reply-To: <CAKuRcOJi5C1C63Y41dSJ0-YsaTni1AL=d3qH2Cjz74C8ardEpQ@mail.gmail.com>
Hi,
On 10/08/2013 02:44 PM, Yuvaraj Kumar wrote:
> On Fri, Oct 4, 2013 at 6:03 AM, Jingoo Han <jg1.han@samsung•com> wrote:
>> On Thursday, October 03, 2013 8:32 PM, Bartlomiej Zolnierkiewicz wrote:
>>> On Tuesday, October 01, 2013 12:03:01 PM Yuvaraj Kumar C D wrote:
>>>> Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible
>>>> ahci_platform driver is not sufficient to handle the AHCI PHY and PHY
>>>> clock related initialization.
>>>>
>>>> This patch adds exynos specific ahci sata driver,contained the exynos
>>>> specific initialized codes, re-use the generic ahci_platform driver, and
>>>> keep the generic ahci_platform driver clean as much as possible.
>>>>
>>>> This patch depends on the below patch
>>>> [1].drivers: phy: add generic PHY framework
>>>> by Kishon Vijay Abraham I<kishon@ti•com>
>>>>
>>>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung•com>
>>>> ---
>>>> drivers/ata/Kconfig | 9 ++
>>>> drivers/ata/Makefile | 1 +
>>>> drivers/ata/ahci_exynos.c | 226 +++++++++++++++++++++++++++++++++++++++++++++
>>>> 3 files changed, 236 insertions(+)
>>>> create mode 100644 drivers/ata/ahci_exynos.c
>>>>
>>
>>
>> [.....]
>>
>>>> + priv->phy = devm_phy_get(dev , "sata-phy");
>>>> + if (IS_ERR(priv->phy))
>>>> + return PTR_ERR(priv->phy);
>>
>> [.....]
>>
>>> Also please take a look at the following patch:
>>>
>>> https://lkml.org/lkml/2013/9/19/173
>>>
>>> it adds PHY support to ahci_platform driver, maybe it can be used
>>> for your needs as well.
>>
>> I also agree with Bartlomiej Zolnierkiewicz's opinion.
>> 'ahci_exynos.c' just calls PHY API, without any additional control
>> for Exynos AHCI IP.
> In addition to PHY handling,it also deals with the special clock
> sclk_sata which is not dealt in ahci_platform.c(certainly exynos
> specific).
>
> Morever there is a wrapper driver to handle the platform specific
> things for the sata.Please refer the patch[1]
> [1]ata: ti_sata: Add Texas Instruments SATA Wrapper driver
> https://lkml.org/lkml/2013/9/19/166
This driver doesn't do anything at the moment since the OMAP hwmod layer
takes care of enabling the relevant clocks. So I was planning to drop it
for now.
>
> [2]ahci_imx: add ahci sata support on imx platforms
>
> I think, if we have platform specific driver like ahci_xxx.c , it
> would be better to handle the sata PHY in ahci_xxx.c so that we can
> retain and re-use the ahci_platform.c as it is.
>
The Generic PHY framework [3] has been merged into Greg's usb-next branch.
The operations there are pretty generic and IMO the PHY can be handled in
the ahci_platform driver.
[3] Generic PHY framework
https://lkml.org/lkml/2013/9/27/581
cheers,
-roger
> Further comments will be much appreciated.
>
>>
>> Best regards,
>> Jingoo Han
>>
>>>
>>>> + ret = phy_init(priv->phy);
>>>> + if (ret < 0) {
>>>> + dev_err(dev, "failed to init SATA PHY\n");
>>>> + return ret;
>>>> + }
>>>> +
>>
next prev parent reply other threads:[~2013-10-08 11:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 6:33 [PATCH 0/3] Exynos5250 SATA Support Yuvaraj Kumar C D
2013-10-01 6:33 ` [PATCH 1/3] ahci: exynos: add ahci sata support on Exynos platform Yuvaraj Kumar C D
2013-10-01 6:54 ` Sachin Kamat
2013-10-01 12:36 ` Kishon Vijay Abraham I
2013-10-03 11:32 ` Bartlomiej Zolnierkiewicz
2013-10-04 0:33 ` Jingoo Han
2013-10-08 11:44 ` Yuvaraj Kumar
2013-10-08 11:59 ` Roger Quadros [this message]
2013-10-11 6:49 ` Jingoo Han
2013-10-11 7:26 ` Tomasz Figa
2013-10-01 6:33 ` [PATCH 2/3] Phy: Exynos: Add Exynos5250 sata phy driver Yuvaraj Kumar C D
2013-10-01 8:15 ` Sachin Kamat
2013-10-01 12:51 ` Kishon Vijay Abraham I
2013-10-07 14:05 ` Yuvaraj Cd
2013-11-14 5:48 ` Kishon Vijay Abraham I
2013-11-15 5:47 ` Yuvaraj Kumar
2013-11-19 9:52 ` Kishon Vijay Abraham I
2013-11-19 10:12 ` Yuvaraj Kumar
2013-11-19 10:40 ` Kishon Vijay Abraham I
2013-10-01 6:33 ` [PATCH 3/3] ARM: dts: Enable ahci sata and sata phy Yuvaraj Kumar C D
2013-10-01 6:46 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5253F3A1.8090906@ti.com \
--to=rogerq@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox