From: ldewangan@nvidia•com (Laxman Dewangan)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2] clk: palmas: add clock driver for palmas
Date: Tue, 8 Oct 2013 18:45:05 +0530 [thread overview]
Message-ID: <52540559.6030406@nvidia.com> (raw)
In-Reply-To: <20131008010237.7445.32387@quantum>
On Tuesday 08 October 2013 06:32 AM, Mike Turquette wrote:
> Quoting Laxman Dewangan (2013-10-07 07:05:51)
>> + if (!ret) {
>> + switch (prop) {
>> + case 1:
>> + prop = PALMAS_EXT_CONTROL_ENABLE1;
>> + break;
>> + case 2:
>> + prop = PALMAS_EXT_CONTROL_ENABLE2;
>> + break;
>> + case 3:
>> + prop = PALMAS_EXT_CONTROL_NSLEEP;
>> + break;
> Can magic numbers be replaced with defines?
Fine, will do in V3.
>
>
> +
> + ret = palmas_update_bits(palmas_clks->palmas, PALMAS_RESOURCE_BASE,
> + cinfo->clk_desc->control_reg,
> + cinfo->clk_desc->sleep_mask, 0);
> What does this call to palmas_update_bits do?
This APIs update the selected bits based on mask. This is wrapper over
the regmap_update_bits() to provide the interface at the Palmas register
access.
The palmas registers are paged on different i2c address and offset. The
i2c address and offset is decided based on base_address and offset.
This APIs does all calculation to get the correct i2c slave address and
offset address based on argument.
>> +static int palmas_clks_remove(struct platform_device *pdev)
>> +{
>> + of_clk_del_provider(pdev->dev.of_node);
> I'll be taking Sylwester's clock deregistration series after he
> publishes the next version, so if you want to call clk_unregister here
> (based on the new call) you could.
>
> If you want to add that in a later patch it is OK.
Thanks for pointing me this changes. I like to add this on my follow on
(later) patch, not on this. -- 1.7.1.1
next prev parent reply other threads:[~2013-10-08 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 14:05 [PATCH V2] clk: palmas: add clock driver for palmas Laxman Dewangan
2013-10-07 14:23 ` Laxman Dewangan
2013-10-08 1:02 ` Mike Turquette
2013-10-08 13:15 ` Laxman Dewangan [this message]
2013-10-08 14:15 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52540559.6030406@nvidia.com \
--to=ldewangan@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox