public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: emilio@elopez•com.ar (Emilio López)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] ARM: sun6i: Add the reset controller to the DTSI
Date: Wed, 09 Oct 2013 08:32:35 -0300	[thread overview]
Message-ID: <52553ED3.5040802@elopez.com.ar> (raw)
In-Reply-To: <1380983960-11087-5-git-send-email-maxime.ripard@free-electrons.com>

Hi Maxime,

El 05/10/13 11:39, Maxime Ripard escribi?:
> The A31 has a reset controller IP that maintains a few other IPs in
> reset, among which we can find the UARTs, high speed timers or the I2C.
> Now that we have support for them, add the reset controllers to the DTSI.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons•com>
> ---
>   arch/arm/boot/dts/sun6i-a31.dtsi | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
> index f244f5f..c99c946 100644
> --- a/arch/arm/boot/dts/sun6i-a31.dtsi
> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
> @@ -209,6 +209,24 @@
>   			};
>   		};
>
> +		ahb1_rst: reset at 01c202c0 {
> +			#reset-cells = <1>;
> +			compatible = "allwinner,sun6i-a31-ahb1-reset";
> +			reg = <0x01c202c0 0xc>;
> +		};
> +
> +		apb1_rst: reset at 01c202d0 {
> +			#reset-cells = <1>;
> +			compatible = "allwinner,sun6i-a31-apb1-reset";
> +			reg = <0x01c202d0 0x4>;
> +		};
> +
> +		apb2_rst: reset at 01c202d8 {
> +			#reset-cells = <1>;
> +			compatible = "allwinner,sun6i-a31-apb2-reset";
> +			reg = <0x01c202d8 0x4>;
> +		};
> +
>   		timer at 01c20c00 {
>   			compatible = "allwinner,sun4i-timer";
>   			reg = <0x01c20c00 0xa0>;
> @@ -232,6 +250,7 @@
>   			reg-shift = <2>;
>   			reg-io-width = <4>;
>   			clocks = <&apb2_gates 16>;
> +			resets = <&apb2_rst 16>;
>   			status = "disabled";
>   		};
>
> @@ -242,6 +261,7 @@
>   			reg-shift = <2>;
>   			reg-io-width = <4>;
>   			clocks = <&apb2_gates 17>;
> +			resets = <&apb2_rst 17>;
>   			status = "disabled";
>   		};
>
> @@ -252,6 +272,7 @@
>   			reg-shift = <2>;
>   			reg-io-width = <4>;
>   			clocks = <&apb2_gates 18>;
> +			resets = <&apb2_rst 18>;
>   			status = "disabled";
>   		};
>
> @@ -262,6 +283,7 @@
>   			reg-shift = <2>;
>   			reg-io-width = <4>;
>   			clocks = <&apb2_gates 19>;
> +			resets = <&apb2_rst 19>;
>   			status = "disabled";
>   		};
>
> @@ -272,6 +294,7 @@
>   			reg-shift = <2>;
>   			reg-io-width = <4>;
>   			clocks = <&apb2_gates 20>;
> +			resets = <&apb2_rst 20>;
>   			status = "disabled";
>   		};
>
> @@ -282,6 +305,7 @@
>   			reg-shift = <2>;
>   			reg-io-width = <4>;
>   			clocks = <&apb2_gates 21>;
> +			resets = <&apb2rst 21>;

You have a typo here (missing _) which breaks the dt build

>   			status = "disabled";
>   		};
>
>

Cheers,

Emilio

  reply	other threads:[~2013-10-09 11:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-05 14:39 [PATCH 0/4] Add support for the Allwinner A31 Reset Controllers Maxime Ripard
2013-10-05 14:39 ` [PATCH 1/4] reset: Add Allwinner A31 Reset Controller Driver Maxime Ripard
2013-10-05 14:39 ` [PATCH 2/4] ARM: sunxi: Select ARCH_HAS_RESET_CONTROLLER Maxime Ripard
2013-10-05 14:39 ` [PATCH 3/4] ARM: sunxi: Register the A31 reset IP in init_time Maxime Ripard
2013-10-05 14:39 ` [PATCH 4/4] ARM: sun6i: Add the reset controller to the DTSI Maxime Ripard
2013-10-09 11:32   ` Emilio López [this message]
2013-10-05 23:32 ` [linux-sunxi] [PATCH 0/4] Add support for the Allwinner A31 Reset Controllers Arokux X
2013-10-06  8:29   ` Maxime Ripard
2013-10-06  9:42     ` Arokux X
2013-10-07 14:26       ` Maxime Ripard
2013-10-07 19:57         ` Arokux X
2013-10-07 20:25           ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52553ED3.5040802@elopez.com.ar \
    --to=emilio@elopez$(echo .)com.ar \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox