From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 00/12] clk/exynos convert clock IDs to macros
Date: Mon, 28 Oct 2013 08:03:56 -0700 [thread overview]
Message-ID: <526E7CDC.3070306@samsung.com> (raw)
In-Reply-To: <526E7553.8030607@samsung.com>
On 10/28/13 07:31, Andrzej Hajda wrote:
> Ping
>
> Regards
> Andrzej
>
> On 10/07/2013 10:46 AM, Andrzej Hajda wrote:
>> On 10/06/2013 10:27 PM, Mike Turquette wrote:
>>> Quoting Kukjin Kim (2013-10-04 19:16:56)
>>>> Mike Turquette wrote:
>>>>> Quoting Kukjin Kim (2013-09-30 03:11:41)
>>>>>> Mike Turquette wrote:
>>>>>>> Quoting Sylwester Nawrocki (2013-09-16 07:33:45)
>>>>>>>> On 09/12/2013 12:50 PM, Kukjin Kim wrote:
>>>>>>>>> Well...I'm not sure changing to use macro is better or not at this
>>>>>>> moment...
>>>>>>>> I think it is. ;) It's really less error prone to have symbolic
>>>>> names
>>>>>>> instead
>>>>>>>> of the plain numbers. The clock ids are defined in one place and it
>>>>> is
>>>>>>> more
>>>>>>>> clear what a clock is by looking at symbolic name. It's especially
>>>>>>> annoying
>>>>>>>> to use plain numbers where are are many clock in a single node, like
>>>>> 10
>>>>>>> or
>>>>>>>> more. What are you main concerns with this ?
>>>>>>> I think having the symbolic names is a win for readability.
>>>>>>>
>>>>>> Hmm...since Mike who is a maintainer for ccf agrees with Sylwester's
>>>>> opinion, so I agree. Actually, I had no strong objection on this but still
>>>>> I'm not sure using macro is really better because sometimes the name
>>>>> doesn't give readability really I think though.
>>>>>> Mike, can you give me your ack on clk stuff?
>>>>> Yes, but I was thinking to take this change through the clk tree. The
>>>>> new branch based on -rc3 will be published tonight.
>>>>>
>>>>> Let me know if it causes problems for you for me to take it.
>>>>>
>>>> Uhm, I think dt changes can make ugly conflicts because of spread dt changing?
>>> Sure, go ahead and take the patches then.
>>>
>>> Acked-by: Mike Turquette<mturquette@linaro•org>
>>>
>>> Regards,
>>> Mike
>>
>> I can create patchset based on different git branch if neccessary.
>>
Hi
Unfortunately, this changes would be merged after release of next rc1
because of too many conflicts with other DT changes in Samsung tree.
Thanks,
Kukjin
prev parent reply other threads:[~2013-10-28 15:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 10:12 [PATCH v2 00/12] clk/exynos convert clock IDs to macros Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 01/12] ARM: exynos4: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 02/12] ARM: dts: exynos4: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 03/12] clk: exynos4: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 04/12] ARM: exynos5250: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 05/12] ARM: dts: exynos5250: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 06/12] clk: exynos5250: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 07/12] ARM: exynos5420: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 08/12] ARM: dts: exynos5420: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 09/12] clk: exynos5420: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 10/12] ARM: exynos5440: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 11/12] ARM: dts: exynos5440: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 12/12] clk: exynos5440: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 11:19 ` [PATCH v2 00/12] clk/exynos convert clock IDs to macros Tomasz Figa
2013-09-12 10:50 ` Kukjin Kim
2013-09-12 11:12 ` Tomasz Figa
2013-09-16 14:33 ` Sylwester Nawrocki
2013-09-16 19:37 ` Mike Turquette
2013-09-26 12:21 ` Andrzej Hajda
2013-09-30 10:11 ` Kukjin Kim
2013-10-02 1:09 ` Mike Turquette
2013-10-05 2:16 ` Kukjin Kim
2013-10-06 20:27 ` Mike Turquette
2013-10-07 8:46 ` Andrzej Hajda
2013-10-28 14:31 ` Andrzej Hajda
2013-10-28 15:03 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E7CDC.3070306@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox