From: Sudeep.KarkadaNagesha@arm•com (Sudeep KarkadaNagesha)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH -next v2] arm64: use for_each_node_by_type() macro
Date: Wed, 30 Oct 2013 14:22:35 +0000 [thread overview]
Message-ID: <5271162B.9070804@arm.com> (raw)
In-Reply-To: <20131030121610.GJ3975@mbp>
On 30/10/13 12:16, Catalin Marinas wrote:
> On Wed, Oct 30, 2013 at 11:49:12AM +0000, Sudeep KarkadaNagesha wrote:
>> On 30/10/13 05:54, Wei Yongjun wrote:
>>> From: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
>>>
>>> Use for_each_node_by_type() macro instead of open coding it.
>>>
>>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
>>> ---
>>> v1 -> v2: remove extra space
>>> ---
>>> arch/arm64/kernel/cpu_ops.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c
>>> index aa0c9e7..37a4977 100644
>>> --- a/arch/arm64/kernel/cpu_ops.c
>>> +++ b/arch/arm64/kernel/cpu_ops.c
>>> @@ -78,10 +78,10 @@ int __init cpu_read_ops(struct device_node *dn, int cpu)
>>>
>>> void __init cpu_read_bootcpu_ops(void)
>>> {
>>> - struct device_node *dn = NULL;
>>> + struct device_node *dn;
>>> u64 mpidr = cpu_logical_map(0);
>>>
>>> - while ((dn = of_find_node_by_type(dn, "cpu"))) {
>>> + for_each_node_by_type(dn, "cpu") {
>>> u64 hwid;
>>> const __be32 *prop;
>>>
>>
>> In fact this function can be simplified by making use of OF helper directly,
>> something like below snippet. But it requires [1] for correct functionality.
>
> Thanks. Could you please send a properly formatted patch on top of [1]?
Yes it's done [2]
Regards,
Sudeep
[2] http://www.spinics.net/lists/arm-kernel/msg283243.html
prev parent reply other threads:[~2013-10-30 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 5:25 [PATCH -next] arm64: use for_each_node_by_type() macro Wei Yongjun
2013-10-30 5:35 ` Rob Herring
2013-10-30 5:54 ` [PATCH -next v2] " Wei Yongjun
2013-10-30 10:54 ` Catalin Marinas
2013-10-30 11:49 ` Sudeep KarkadaNagesha
2013-10-30 12:16 ` Catalin Marinas
2013-10-30 14:22 ` Sudeep KarkadaNagesha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5271162B.9070804@arm.com \
--to=sudeep.karkadanagesha@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox