From: sboyd@codeaurora•org (Stephen Boyd)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] dmaengine: add msm bam dma driver
Date: Wed, 30 Oct 2013 13:46:20 -0700 [thread overview]
Message-ID: <5271701C.3010706@codeaurora.org> (raw)
In-Reply-To: <20131030203105.GA14525@agross>
On 10/30/13 13:31, Andy Gross wrote:
> On Tue, Oct 29, 2013 at 10:56:03AM -0700, Stephen Boyd wrote:
>> On 10/25, Andy Gross wrote:
>>> +#include <linux/scatterlist.h>
>>> +#include <linux/device.h>
>>> +#include <linux/platform_device.h>
>>> +#include <linux/of.h>
>>> +#include <linux/of_address.h>
>>> +#include <linux/of_irq.h>
>>> +#include <linux/of_dma.h>
>>> +#include <linux/clk.h>
>>> +#include <linux/msm_bam_dma.h>
>>> +
>>> +#include "dmaengine.h"
>>> +#include "msm_bam_dma_priv.h"
>> Why do we need this file? Can't we just put the #defines in this
>> file?
>
> There were enough definitions and structures to warrant another file.
>
Ah ok. I find it annoying to flip between two files but I guess that's
my problem.
>>> + if (!bdev) {
>>> + dev_err(&pdev->dev, "insufficient memory for private data\n");
>> kmalloc calls already print errors when they fail, so this can be
>> removed.
>
> has this always been the case?
The warning in the page allocator seems to have been there since pre-git
days (see __alloc_pages_slowpath() and how it calls warn_alloc_failed())
. Other warnings in the sl*b allocators seem to have come later (see
8bdec192b40cf7f7eec170b317c76089eb5eeddb for example).
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-10-30 20:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 20:24 [PATCH 0/2] add MSM BAM dmaengine driver Andy Gross
2013-10-25 20:24 ` [PATCH 1/2] dmaengine: add msm bam dma driver Andy Gross
2013-10-29 17:56 ` Stephen Boyd
2013-10-30 20:31 ` Andy Gross
2013-10-30 20:46 ` Stephen Boyd [this message]
2013-11-13 22:07 ` Tomasz Figa
2013-10-31 16:59 ` Vinod Koul
2013-10-31 21:46 ` Andy Gross
2013-11-07 23:03 ` Andy Gross
2013-11-13 13:18 ` Vinod Koul
2013-11-13 21:03 ` Andy Gross
2013-10-25 20:24 ` [PATCH 2/2] dmaengine: msm_bam_dma: Add device tree binding Andy Gross
2013-10-25 21:31 ` Kumar Gala
2013-10-25 23:20 ` Grant Likely
2013-10-29 6:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5271701C.3010706@codeaurora.org \
--to=sboyd@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox