From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] ARM: shmobile: Koelsch: add Ether support
Date: Thu, 31 Oct 2013 22:46:57 +0300 [thread overview]
Message-ID: <5272B3B1.8090503@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoTNJAnqavonOwtqe5_HDdPwK1-JAixNuz5z7ttQw-T64Q@mail.gmail.com>
Hello.
On 10/31/2013 11:10 AM, Magnus Damm wrote:
>> Register Ether platform device and pin data on the Koelsch board.
>> Register platform fixup for Micrel KSZ8041 PHY, just like on the Lager board.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
>> ---
>> arch/arm/mach-shmobile/board-koelsch.c | 61 ++++++++++++++++++++++++++++++++-
>> 1 file changed, 60 insertions(+), 1 deletion(-)
>>
>> Index: renesas/arch/arm/mach-shmobile/board-koelsch.c
>> ===================================================================
>> --- renesas.orig/arch/arm/mach-shmobile/board-koelsch.c
>> +++ renesas/arch/arm/mach-shmobile/board-koelsch.c
>> @@ -70,11 +87,29 @@ static const struct gpio_keys_platform_d
>> .nbuttons = ARRAY_SIZE(gpio_buttons),
>> };
>>
>> +static const struct pinctrl_map koelsch_pinctrl_map[] = {
>> + /* Ether */
>> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7791",
>> + "eth_link", "eth"),
>> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7791",
>> + "eth_mdio", "eth"),
>> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7791",
>> + "eth_rmii", "eth"),
>> +};
> Once again we seem to be using r8a7790 when the actual SoC is r8a7791.
Note that the last time it was in the DT context which is not quite the
same as platfrom device context.
> If you're going to go down the route of using the SoC name then please
I don't have much choice here. Though we could have used used R-Car
gen1/gen2 terminology (at least in the hindsight)...
> use the correct one at least.
It wasn't me who used "r8a7790-ether" name in the first place, it was
Simon. And as these 2 SoCs are indistinguishable at least from the 'sh_eth'
driver's point of view, I wouldn't want to introduce another platform device
ID, especially as it hasn't been done for R8A777[89] SoCs. What I can offer is
renaming "r8a7790-ether" to "r8a779x-ether" if you really want.
> Cheers,
> / magnus
WBR, Sergei
prev parent reply other threads:[~2013-10-31 19:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 23:16 [PATCH 0/2] Add Ether support for R8A7791/Koelsch board Sergei Shtylyov
2013-10-30 23:18 ` [PATCH 1/2] ARM: shmobile: r8a7791: add Ether clock Sergei Shtylyov
2013-10-31 6:06 ` Simon Horman
2013-10-31 21:50 ` Sergei Shtylyov
2013-11-01 6:29 ` Simon Horman
2013-10-30 23:19 ` [PATCH 2/2] ARM: shmobile: Koelsch: add Ether support Sergei Shtylyov
2013-10-31 5:02 ` Simon Horman
2013-10-31 21:24 ` Sergei Shtylyov
2013-10-31 8:06 ` Magnus Damm
2013-10-31 19:03 ` Sergei Shtylyov
2013-12-09 19:57 ` Sergei Shtylyov
2013-12-09 22:14 ` Sergei Shtylyov
2013-12-18 21:23 ` Sergei Shtylyov
2013-10-31 8:10 ` Magnus Damm
2013-10-31 19:46 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5272B3B1.8090503@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox