public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls
Date: Sat, 2 Nov 2013 22:46:55 +0530	[thread overview]
Message-ID: <52753387.5030202@ti.com> (raw)
In-Reply-To: <2395941.Lp2U7sdS37@flatron>

Hi Tomasz,

On Saturday 02 November 2013 06:44 PM, Tomasz Figa wrote:
> Hi Matt,
>
> On Friday 01 of November 2013 15:45:50 Matt Porter wrote:
>> This adds a pair of APIs that allows the generic PHY subsystem to
>> provide information on the PHY bus width. The PHY provider driver may
>> use phy_set_bus_width() to set the bus width that the PHY supports.
>> The controller driver may then use phy_get_bus_width() to fetch the
>> PHY bus width in order to properly configure the controller.
>
> I somehow does not like this. If we take this path for any further
> properties that we may need, we will end up with a lot of consumer
> specific properties stored in a PHY object having their own accessor
> functions.

Only after all of us feel that a property is *generic* enough, we allow 
it to be added in the PHY object.
>
> Since this is just an integration detail, what about simply adding this as
> a property in device tree node of the OTG controller (and pdata if
> considering non-DT support)?

We already had a discussion about this and the dt maintainers suggested 
the property should be in the PHY. [1]

[1] ->  http://www.spinics.net/lists/devicetree/msg08851.html

Thanks
Kishon

next prev parent reply	other threads:[~2013-11-02 17:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-01 19:45 [PATCH v2 0/9] USB Device Controller support for BCM281xx Matt Porter
2013-11-01 19:45 ` [PATCH v2 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls Matt Porter
2013-11-02 13:14   ` Tomasz Figa
2013-11-02 17:16     ` Kishon Vijay Abraham I [this message]
2013-11-02 17:47       ` Matt Porter
2013-11-02 17:58         ` Tomasz Figa
2013-11-04  6:04           ` Kishon Vijay Abraham I
2013-11-01 19:45 ` [PATCH v2 2/9] staging: dwc2: update DT binding to add generic clock/phy properties Matt Porter
2013-11-01 19:45 ` [PATCH v2 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter
2013-11-01 19:45 ` [PATCH v2 4/9] usb: gadget: s3c-hsotg: add snps, dwc2 compatible string Matt Porter
2013-11-01 19:45 ` [PATCH v2 5/9] usb: gadget: s3c-hsotg: enable generic phy support Matt Porter
2013-11-02 13:09   ` Tomasz Figa
2013-11-02 17:52     ` Matt Porter
2013-11-01 19:45 ` [PATCH v2 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem Matt Porter
2013-11-01 19:45 ` [PATCH v2 7/9] phy: add Broadcom Kona USB2 PHY DT binding Matt Porter
2013-11-01 20:54   ` Arend van Spriel
2013-11-01 22:56     ` Matt Porter
2013-11-01 19:45 ` [PATCH v2 8/9] phy: add Broadcom Kona USB2 PHY driver Matt Porter
2013-11-04  6:27   ` Kishon Vijay Abraham I
2013-11-25 14:16     ` Matt Porter
2013-11-01 19:45 ` [PATCH v2 9/9] ARM: dts: add usb udc support to bcm281xx Matt Porter
2013-11-01 20:56   ` Sergei Shtylyov
2013-11-01 22:52     ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52753387.5030202@ti.com \
    --to=kishon@ti$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox