From: jonathan.austin@arm•com (Jonathan Austin)
To: linux-arm-kernel@lists•infradead.org
Subject: kernel BUG at kernel/kallsyms.c:222!
Date: Mon, 11 Nov 2013 17:15:29 +0000 [thread overview]
Message-ID: <528110B1.4060402@arm.com> (raw)
In-Reply-To: <CACVXFVOnVXcVdRCm=OfPjpvvWCiXi8GRV+9ViOGmSZ3tTf6WDg@mail.gmail.com>
On 11/11/13 10:41, Ming Lei wrote:
> Hi,
>
> On Mon, Nov 11, 2013 at 5:57 PM, Ming Lei <tom.leiming@gmail•com> wrote:
>> Hi,
>>
>> On Mon, Nov 11, 2013 at 4:37 PM, Axel Lin <axel.lin@ingics•com> wrote:
>>> 2013/11/11 Ming Lei <tom.leiming@gmail•com>:
>>>
>>> Hi Ming,
>>>
>>> commit f6537f2f "scripts/kallsyms: filter symbols not in kernel address space",
>>> uses CONFIG_PAGE_OFFSET as kernel_start_addr.
>>> However, for !CONFIG_MMU case we have :
>>> PAGE_OFFSET != CONFIG_PAGE_OFFSET.
>>
>> Yes, it is the cause, and strictly speaking, commit f6537f2f is wrong,
>> but triggered with bogus CONFIG_PAGE_OFFSET if !CONFIG_MMU.
>>
>> We can fix it either by Rusty's patch or removing the bogus
>> CONFIG_PAGE_OFFSET for !CONFIG_MMU.
>
> Rusty, maybe we need revert commit f6537f2f "scripts/kallsyms: filter
> symbols not in kernel address space", since CONFIG_PAGE_OFFSET
> may be bogus on !MMU or not defined on ARCHs(most of 64bit arch,
> no regression report because scripts/kallsyms may get zero
> kernel_start_addr)
>
For me on Cortex-R7 (nommu) f6537f2f breaks boot (Oops very early on...)
and reverting it fixes the problem... However, as you note, we have a
'bogus' CONFIG_PAGE_OFFSET (0xC0000000) for !MMU so another approach would
be to fix that...
I've tested the patch below and it solves the ARM side of things - so
gives you an option other than a complete revert. Happy to put this in to
RMK's patch system if you'd prefer not to have to revert and he's happy
with the patch.
Jonny
-------->8-----------
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index d601be3..6756651 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1609,6 +1609,7 @@ endchoice
config PAGE_OFFSET
hex
+ default PHYS_OFFSET if !MMU
default 0x40000000 if VMSPLIT_1G
default 0x80000000 if VMSPLIT_2G
default 0xC0000000
next prev parent reply other threads:[~2013-11-11 17:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1383789208.5970.1.camel@phoenix>
[not found] ` <CACVXFVMn6RSXchQ8u47F35_J+YSnp1bwF1tr-8uCEYwvFsOfgQ@mail.gmail.com>
[not found] ` <CAFRkauAEt-YhBt11opj_GVCLrxGsTSd2LowWGmukTSmGuJkd3A@mail.gmail.com>
2013-11-07 2:36 ` kernel BUG at kernel/kallsyms.c:222! Ming Lei
2013-11-07 2:47 ` Axel Lin
2013-11-07 4:37 ` Ming Lei
2013-11-07 8:36 ` Axel Lin
2013-11-07 23:44 ` Rusty Russell
2013-11-08 0:45 ` Ming Lei
2013-11-08 4:20 ` Axel Lin
2013-11-08 7:13 ` Ming Lei
2013-11-11 0:23 ` Rusty Russell
2013-11-11 6:43 ` Axel Lin
2013-11-11 7:53 ` Ming Lei
2013-11-11 8:37 ` Axel Lin
2013-11-11 9:57 ` Ming Lei
2013-11-11 10:41 ` Ming Lei
2013-11-11 17:15 ` Jonathan Austin [this message]
2013-11-11 19:32 ` Russell King - ARM Linux
2013-11-12 3:22 ` Ming Lei
2013-11-12 17:36 ` Jonathan Austin
2013-11-13 4:41 ` Ming Lei
2013-11-13 9:58 ` Axel Lin
2013-11-13 11:30 ` Ming Lei
2013-12-02 1:57 ` Axel Lin
2013-12-02 2:08 ` Ming Lei
2013-12-10 6:17 ` Rusty Russell
2013-11-11 8:01 ` Uwe Kleine-König
2013-11-08 3:56 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528110B1.4060402@arm.com \
--to=jonathan.austin@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox