From: taras.kondratiuk@linaro•org (Taras Kondratiuk)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: kexec: Use the right ISA for relocate_new_kernel
Date: Tue, 12 Nov 2013 21:29:15 +0200 [thread overview]
Message-ID: <5282818B.9030903@linaro.org> (raw)
In-Reply-To: <20131108184625.GE2602@localhost.localdomain>
Hi Dave
Yes. I've tested it on Pandaboard and results are quite weird.
ARM->ARM, Thumb->Thumb and Thumb->ARM kernel transition works fine
for both kexec and kdump ways. But ARM->Thumb works for only kdump
via kernel panic. In case of "kexec -e" the second Thumb kernel
doesn't come up.
I don't have JTAG now. I will check this tomorrow morning.
On 8 November 2013 20:46, Dave Martin <Dave.Martin@arm•com> wrote:
> On Fri, Nov 08, 2013 at 01:34:27PM +0000, Will Deacon wrote:
>> On Fri, Nov 08, 2013 at 12:24:04PM +0000, Dave Martin wrote:
>> > Copying a function with memcpy() and then trying to execute the
>> > result isn't trivially portable to Thumb.
>> >
>> > This patch modifies the kexec soft restart code to copy its
>> > assembler trampoline relocate_new_kernel() using fncpy() instead,
>> > so that relocate_new_kernel can be in the same ISA as the rest of
>> > the kernel without problems.
>> >
>> > Signed-off-by: Dave Martin <Dave.Martin@arm•com>
>> > ---
>> > Changes since v1:
>> >
>> > * Move ENDPROC() after relocate_new_kernel's literals, to be
>> > consistent the location of relocate_new_kernel_end and with the way
>> > GCC sets ELF symbol sizes for functions. This is just a tidyup,
>> > with no functional impact.
>>
>> Cheers Dave:
>>
>> Acked-by: Will Deacon <will.deacon@arm•com>
>
> Thanks
>
>
> Are you still in a position to test this, Taras?
>
> Cheers
> ---Dave
--
Regards,
Taras Kondratiuk
next prev parent reply other threads:[~2013-11-12 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 12:24 [PATCH v2] ARM: kexec: Use the right ISA for relocate_new_kernel Dave Martin
2013-11-08 13:34 ` Will Deacon
2013-11-08 18:46 ` Dave Martin
2013-11-12 19:29 ` Taras Kondratiuk [this message]
2013-11-15 11:28 ` Taras Kondratiuk
2013-11-15 17:38 ` Dave Martin
2013-11-15 18:11 ` Taras Kondratiuk
2013-11-15 18:33 ` Dave P Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5282818B.9030903@linaro.org \
--to=taras.kondratiuk@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox